Re: [libvirt] [PATCH 7/7] tests: Add tests for fc_host

2013-05-14 Thread Eric Blake
On 05/14/2013 12:31 PM, Gene Czarcinski wrote: > On 05/14/2013 01:42 PM, Osier Yang wrote: >> On 15/05/13 00:35, Gene Czarcinski wrote: >>> On 05/13/2013 05:32 AM, Osier Yang wrote: On 08/05/13 23:03, Osier Yang wrote: > On 08/05/13 21:53, John Ferlan wrote: >> On 05/06/2013 08:45 AM,

Re: [libvirt] [PATCH 7/7] tests: Add tests for fc_host

2013-05-14 Thread Gene Czarcinski
On 05/14/2013 01:42 PM, Osier Yang wrote: On 15/05/13 00:35, Gene Czarcinski wrote: On 05/13/2013 05:32 AM, Osier Yang wrote: On 08/05/13 23:03, Osier Yang wrote: On 08/05/13 21:53, John Ferlan wrote: On 05/06/2013 08:45 AM, Osier Yang wrote: Since the NPIV machine is not easy to get, it's v

Re: [libvirt] [PATCH 7/7] tests: Add tests for fc_host

2013-05-14 Thread Osier Yang
On 15/05/13 00:35, Gene Czarcinski wrote: On 05/13/2013 05:32 AM, Osier Yang wrote: On 08/05/13 23:03, Osier Yang wrote: On 08/05/13 21:53, John Ferlan wrote: On 05/06/2013 08:45 AM, Osier Yang wrote: Since the NPIV machine is not easy to get, it's very likely to introduce regressions when do

Re: [libvirt] [PATCH 7/7] tests: Add tests for fc_host

2013-05-14 Thread Gene Czarcinski
On 05/13/2013 05:32 AM, Osier Yang wrote: On 08/05/13 23:03, Osier Yang wrote: On 08/05/13 21:53, John Ferlan wrote: On 05/06/2013 08:45 AM, Osier Yang wrote: Since the NPIV machine is not easy to get, it's very likely to introduce regressions when doing changes on the existing code. This patc

Re: [libvirt] [PATCH 7/7] tests: Add tests for fc_host

2013-05-13 Thread Osier Yang
On 08/05/13 23:03, Osier Yang wrote: On 08/05/13 21:53, John Ferlan wrote: On 05/06/2013 08:45 AM, Osier Yang wrote: Since the NPIV machine is not easy to get, it's very likely to introduce regressions when doing changes on the existing code. This patch dumps part of the sysfs files (the necess

Re: [libvirt] [PATCH 7/7] tests: Add tests for fc_host

2013-05-08 Thread Osier Yang
On 08/05/13 21:53, John Ferlan wrote: On 05/06/2013 08:45 AM, Osier Yang wrote: Since the NPIV machine is not easy to get, it's very likely to introduce regressions when doing changes on the existing code. This patch dumps part of the sysfs files (the necessary ones) of fc_host as test input dat

Re: [libvirt] [PATCH 7/7] tests: Add tests for fc_host

2013-05-08 Thread John Ferlan
On 05/06/2013 08:45 AM, Osier Yang wrote: > Since the NPIV machine is not easy to get, it's very likely to > introduce regressions when doing changes on the existing code. > This patch dumps part of the sysfs files (the necessary ones) > of fc_host as test input data, to test the related util funct

[libvirt] [PATCH 7/7] tests: Add tests for fc_host

2013-05-06 Thread Osier Yang
Since the NPIV machine is not easy to get, it's very likely to introduce regressions when doing changes on the existing code. This patch dumps part of the sysfs files (the necessary ones) of fc_host as test input data, to test the related util functions. It could be extended for more fc_host relate