Re: [libvirt] [PATCH 7/9] conf: Refactor virDomainCachetuneDefParse

2018-07-27 Thread bing.niu
On 2018年07月28日 00:58, John Ferlan wrote: [...] Secondary to that you've added a new error related to identical vcpus in the parsing logic. Unfortunately that could make a domain disappear on a libvirtd restart if for some reason it was already defined in that manner. If there's a parsing er

Re: [libvirt] [PATCH 7/9] conf: Refactor virDomainCachetuneDefParse

2018-07-27 Thread John Ferlan
[...] >> >> Secondary to that you've added a new error related to identical vcpus in >> the parsing logic. Unfortunately that could make a domain disappear on a >> libvirtd restart if for some reason it was already defined in that >> manner. If there's a parsing error because two entries had ide

Re: [libvirt] [PATCH 7/9] conf: Refactor virDomainCachetuneDefParse

2018-07-26 Thread bing.niu
On 2018年07月27日 01:48, John Ferlan wrote: On 07/18/2018 03:57 AM, bing@intel.com wrote: From: Bing Niu Refactoring virDomainCachetuneDefParse, extracting vcpus extracting, overlapping detecting and new resctrl allocation creating logic. Those two logic is common among different resource

Re: [libvirt] [PATCH 7/9] conf: Refactor virDomainCachetuneDefParse

2018-07-26 Thread John Ferlan
On 07/18/2018 03:57 AM, bing@intel.com wrote: > From: Bing Niu > > Refactoring virDomainCachetuneDefParse, extracting vcpus extracting, > overlapping detecting and new resctrl allocation creating logic. > Those two logic is common among different resource allocation > technologies. > > Si

[libvirt] [PATCH 7/9] conf: Refactor virDomainCachetuneDefParse

2018-07-18 Thread bing . niu
From: Bing Niu Refactoring virDomainCachetuneDefParse, extracting vcpus extracting, overlapping detecting and new resctrl allocation creating logic. Those two logic is common among different resource allocation technologies. Signed-off-by: Bing Niu --- src/conf/domain_conf.c | 195