Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-10 Thread Eduardo Habkost
On Tue, May 10, 2016 at 08:32:53AM +0200, David Hildenbrand wrote: > > > > Yes, I think so. However to really make good hints, upper layers would > > > most > > > likely need more information about the exact problem with a property - > > > maybe something like an enum value per problematic proper

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-09 Thread David Hildenbrand
> > Yes, I think so. However to really make good hints, upper layers would most > > likely need more information about the exact problem with a property - > > maybe something like an enum value per problematic property. > > (UNAVAILABLE_FEATURE, VALUE_TOO_BIG, VALUE_TOO_SMALL, UNSUPPORTED_VALUE)

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-09 Thread Eduardo Habkost
On Mon, May 09, 2016 at 03:06:18PM +0200, David Hildenbrand wrote: > > > > > > > > > > Just FYI, on other architectures (e.g. s390x), other conditions (e.g. > > > > > cpu > > > > > generation) also define if a CPU model is runnable, so the pure > > > > > availability of > > > > > features does n

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-09 Thread Eduardo Habkost
On Mon, May 09, 2016 at 09:20:15AM -0600, Eric Blake wrote: > On 05/06/2016 12:11 PM, Eduardo Habkost wrote: > > Extend query-cpu-definitions schema to allow it to return two new > > optional fields: "runnable" and "unavailable-features". > > "runnable" will tell if the CPU model can be run in the

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-09 Thread Eric Blake
On 05/06/2016 12:11 PM, Eduardo Habkost wrote: > Extend query-cpu-definitions schema to allow it to return two new > optional fields: "runnable" and "unavailable-features". > "runnable" will tell if the CPU model can be run in the current > host. "unavailable-features" will contain a list of CPU >

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-09 Thread David Hildenbrand
> > > > > > > > Just FYI, on other architectures (e.g. s390x), other conditions (e.g. > > > > cpu > > > > generation) also define if a CPU model is runnable, so the pure > > > > availability of > > > > features does not mean that a cpu model is runnable. > > > > > > > > We could have runnable=

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-09 Thread Eduardo Habkost
On Mon, May 09, 2016 at 02:05:05PM +0200, David Hildenbrand wrote: > > On Mon, May 09, 2016 at 10:54:53AM +0200, David Hildenbrand wrote: > > > > Extend query-cpu-definitions schema to allow it to return two new > > > > optional fields: "runnable" and "unavailable-features". > > > > "runnable" will

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-09 Thread David Hildenbrand
> On Mon, May 09, 2016 at 10:54:53AM +0200, David Hildenbrand wrote: > > > Extend query-cpu-definitions schema to allow it to return two new > > > optional fields: "runnable" and "unavailable-features". > > > "runnable" will tell if the CPU model can be run in the current > > > host. "unavailable-f

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-09 Thread David Hildenbrand
> Extend query-cpu-definitions schema to allow it to return two new > optional fields: "runnable" and "unavailable-features". > "runnable" will tell if the CPU model can be run in the current > host. "unavailable-features" will contain a list of CPU > properties that are preventing the CPU model fr

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-09 Thread Eduardo Habkost
On Mon, May 09, 2016 at 10:54:53AM +0200, David Hildenbrand wrote: > > Extend query-cpu-definitions schema to allow it to return two new > > optional fields: "runnable" and "unavailable-features". > > "runnable" will tell if the CPU model can be run in the current > > host. "unavailable-features" w

[libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-06 Thread Eduardo Habkost
Extend query-cpu-definitions schema to allow it to return two new optional fields: "runnable" and "unavailable-features". "runnable" will tell if the CPU model can be run in the current host. "unavailable-features" will contain a list of CPU properties that are preventing the CPU model from running