Re: [libvirt] [PATCH 8/8] Avoid unsafe use of /proc/$PID/root in LXC hotunplug code

2014-02-17 Thread Eric Blake
On 02/17/2014 09:39 AM, Daniel P. Berrange wrote: > Rewrite multiple hotunplug functions to to use the > virProcessRunInMountNamespace helper. This avoids > risk of a malicious guest replacing /dev with a absolute s/a absolute/an absolute/ > symlink, tricking the driver into changing the host OS

[libvirt] [PATCH 8/8] Avoid unsafe use of /proc/$PID/root in LXC hotunplug code

2014-02-17 Thread Daniel P. Berrange
Rewrite multiple hotunplug functions to to use the virProcessRunInMountNamespace helper. This avoids risk of a malicious guest replacing /dev with a absolute symlink, tricking the driver into changing the host OS filesystem. Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_driver.c | 79 +++