Re: [libvirt] [PATCH 8/9] qemu: domain: Reflect USB controller model in guest XML

2016-08-12 Thread Andrea Bolognani
On Mon, 2016-08-08 at 18:30 +0200, Ján Tomko wrote: > > I think we still want to make a last-ditch effort to provide > > some sort, any sort, of USB controller. Or rather, that we > > have to. Honestly, I'd rather just drop the -usb handling > > altogether and expect users not to mix modern-day lib

Re: [libvirt] [PATCH 8/9] qemu: domain: Reflect USB controller model in guest XML

2016-08-08 Thread Ján Tomko
On Thu, Aug 04, 2016 at 04:44:34PM +0200, Andrea Bolognani wrote: On Thu, 2016-08-04 at 14:32 +0200, Ján Tomko wrote: > +} else if (cont->type == VIR_DOMAIN_CONTROLLER_TYPE_USB && > +   cont->model == -1) { > +/* Pick a suitable default model for the USB contr

Re: [libvirt] [PATCH 8/9] qemu: domain: Reflect USB controller model in guest XML

2016-08-04 Thread Andrea Bolognani
On Thu, 2016-08-04 at 14:32 +0200, Ján Tomko wrote: > > +} else if (cont->type == VIR_DOMAIN_CONTROLLER_TYPE_USB && > > +   cont->model == -1) { > > +/* Pick a suitable default model for the USB controller if none > > + * has been selected by the user

Re: [libvirt] [PATCH 8/9] qemu: domain: Reflect USB controller model in guest XML

2016-08-04 Thread Ján Tomko
On Fri, Jul 29, 2016 at 07:46:28PM +0200, Andrea Bolognani wrote: When the user doesn't specify any model for a USB controller, we use an architecture-dependent default, but we don't reflect it in the guest XML. Pick the default USB controller model when parsing the guest XML instead of when cre

[libvirt] [PATCH 8/9] qemu: domain: Reflect USB controller model in guest XML

2016-07-29 Thread Andrea Bolognani
When the user doesn't specify any model for a USB controller, we use an architecture-dependent default, but we don't reflect it in the guest XML. Pick the default USB controller model when parsing the guest XML instead of when creating the QEMU command line, so that our choice is saved back to dis