Re: [libvirt] [PATCH 9/9] virhostdevtest: s/virReportError/fprintf/

2019-08-27 Thread Michal Privoznik
On 8/26/19 2:38 PM, Ján Tomko wrote: On Mon, Aug 12, 2019 at 01:54:25PM +0200, Michal Privoznik wrote: If a test fails, it's stderr is caught in the logs. That's how our CI works. But virReportError() is not. Where are you missing the error message? If you run the tested function through virT

Re: [libvirt] [PATCH 9/9] virhostdevtest: s/virReportError/fprintf/

2019-08-26 Thread Ján Tomko
On Mon, Aug 12, 2019 at 01:54:25PM +0200, Michal Privoznik wrote: If a test fails, it's stderr is caught in the logs. That's how our CI works. But virReportError() is not. Where are you missing the error message? If you run the tested function through virTestRun, it calls virDispatchError whic

[libvirt] [PATCH 9/9] virhostdevtest: s/virReportError/fprintf/

2019-08-12 Thread Michal Privoznik
If a test fails, it's stderr is caught in the logs. That's how our CI works. But virReportError() is not. Signed-off-by: Michal Privoznik --- tests/virhostdevtest.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/virhostdevtest.c b/tests/virhostdevtest.c index b64b