Re: [libvirt] [PATCH RFC v3 01/15] storage pools: refactoring of basic structs

2016-12-21 Thread John Ferlan
On 12/21/2016 12:08 PM, Olga Krishtal wrote: > On 20/12/16 20:18, John Ferlan wrote: >> >> On 12/15/2016 12:16 PM, Olga Krishtal wrote: >>> Hi, John. >>> I needed some time to think over everything that you have written. >>> Thanks a lot. >> Yeah - I got too wordy, but this type of change caused

Re: [libvirt] [PATCH RFC v3 01/15] storage pools: refactoring of basic structs

2016-12-21 Thread Olga Krishtal
On 20/12/16 20:18, John Ferlan wrote: On 12/15/2016 12:16 PM, Olga Krishtal wrote: Hi, John. I needed some time to think over everything that you have written. Thanks a lot. Yeah - I got too wordy, but this type of change caused me to think about other possible consumers too. With all this

Re: [libvirt] [PATCH RFC v3 01/15] storage pools: refactoring of basic structs

2016-12-20 Thread John Ferlan
On 12/15/2016 12:16 PM, Olga Krishtal wrote: > Hi, John. > I needed some time to think over everything that you have written. > Thanks a lot. Yeah - I got too wordy, but this type of change caused me to think about other possible consumers too. > With all this new information we have more free

Re: [libvirt] [PATCH RFC v3 01/15] storage pools: refactoring of basic structs

2016-12-15 Thread Olga Krishtal
Hi, John. I needed some time to think over everything that you have written. Thanks a lot. With all this new information we have more freedom for changes and refactoring. I dig through storage_conf.h file once with all ideas you have and tried to use them. It would be easier for me if we agree a

Re: [libvirt] [PATCH RFC v3 01/15] storage pools: refactoring of basic structs

2016-12-07 Thread John Ferlan
On 12/02/2016 10:38 AM, Olga Krishtal wrote: > This is the first patch in fspool patchest. > FSPool and storage pools has a lot in common, however we > want to have separate drivers for its managment. > > We want to use almost all storage pool descriptional structures > for filesystem pool. All

[libvirt] [PATCH RFC v3 01/15] storage pools: refactoring of basic structs

2016-12-02 Thread Olga Krishtal
This is the first patch in fspool patchest. FSPool and storage pools has a lot in common, however we want to have separate drivers for its managment. We want to use almost all storage pool descriptional structures for filesystem pool. All common structs is moved to virpoolcommon.h Signed-off-by: