Re: [libvirt] [PATCH libguestfs 0/4] Add a libvirt backend to libguestfs.

2012-07-23 Thread Richard W.M. Jones
On Mon, Jul 23, 2012 at 11:21:37AM +0100, Daniel P. Berrange wrote: > On Mon, Jul 23, 2012 at 11:02:41AM +0100, Richard W.M. Jones wrote: > > It's using NULL and expecting libvirt to choose the appropriate > > connection URI, which does appear to work. > > Apps should only rely on NULL, if they ar

Re: [libvirt] [PATCH libguestfs 0/4] Add a libvirt backend to libguestfs.

2012-07-23 Thread Daniel P. Berrange
On Mon, Jul 23, 2012 at 11:02:41AM +0100, Richard W.M. Jones wrote: > On Mon, Jul 23, 2012 at 10:45:21AM +0100, Daniel P. Berrange wrote: > > On Sat, Jul 21, 2012 at 09:43:45PM +0100, Richard W.M. Jones wrote: > > > On Sat, Jul 21, 2012 at 08:20:45PM +0100, Richard W.M. Jones wrote: > > > > Some qu

Re: [libvirt] [PATCH libguestfs 0/4] Add a libvirt backend to libguestfs.

2012-07-23 Thread Richard W.M. Jones
On Mon, Jul 23, 2012 at 10:45:21AM +0100, Daniel P. Berrange wrote: > On Sat, Jul 21, 2012 at 09:43:45PM +0100, Richard W.M. Jones wrote: > > On Sat, Jul 21, 2012 at 08:20:45PM +0100, Richard W.M. Jones wrote: > > > Some questions: > > > > Another question ... > > > > > > > >> > path

Re: [libvirt] [PATCH libguestfs 0/4] Add a libvirt backend to libguestfs.

2012-07-23 Thread Daniel P. Berrange
On Sat, Jul 21, 2012 at 09:43:45PM +0100, Richard W.M. Jones wrote: > On Sat, Jul 21, 2012 at 08:20:45PM +0100, Richard W.M. Jones wrote: > > Some questions: > > Another question ... > > > > >> path="/home/rjones/d/libguestfs/libguestfsSSg3Kl/guestfsd.sock"/> > > > > > >

Re: [libvirt] [PATCH libguestfs 0/4] Add a libvirt backend to libguestfs.

2012-07-23 Thread Daniel P. Berrange
On Sat, Jul 21, 2012 at 08:20:45PM +0100, Richard W.M. Jones wrote: > This preliminary patch series adds a libvirt backend to libguestfs. > It's for review only because although it launches the guest OK, there > are some missing features that need to be implemented. > > The meat of the patch is in

Re: [libvirt] [PATCH libguestfs 0/4] Add a libvirt backend to libguestfs.

2012-07-22 Thread Richard W.M. Jones
On Sat, Jul 21, 2012 at 08:20:45PM +0100, Richard W.M. Jones wrote: > This preliminary patch series adds a libvirt backend to libguestfs. > It's for review only because although it launches the guest OK, there > are some missing features that need to be implemented. I did some appliance boot timin

Re: [libvirt] [PATCH libguestfs 0/4] Add a libvirt backend to libguestfs.

2012-07-22 Thread Richard W.M. Jones
On Sat, Jul 21, 2012 at 08:20:45PM +0100, Richard W.M. Jones wrote: > Some questions: How do you set the IP address for userspace networking? AFAICT from the code this is not possible. ie: the net= parameter: -netdev user,id=usernet,net=169.254.0.0/16 \ -device virtio-net-pci,netdev=usernet Ri

Re: [libvirt] [PATCH libguestfs 0/4] Add a libvirt backend to libguestfs.

2012-07-21 Thread Richard W.M. Jones
On Sat, Jul 21, 2012 at 09:43:45PM +0100, Richard W.M. Jones wrote: > (3) SELinux/sVirt prevents qemu connecting to this socket. This one > is a pain. You'd think that if a socket is specified in the libvirt > XML then sVirt should allow access to it. The AVCs are: type=AVC msg=audit(1342903120

Re: [libvirt] [PATCH libguestfs 0/4] Add a libvirt backend to libguestfs.

2012-07-21 Thread Richard W.M. Jones
On Sat, Jul 21, 2012 at 08:20:45PM +0100, Richard W.M. Jones wrote: > Some questions: Another question ... > >path="/home/rjones/d/libguestfs/libguestfsSSg3Kl/guestfsd.sock"/> > > This clause doesn't work when libguestfs/qemu runs as root. As far as I can tell there are

[libvirt] [PATCH libguestfs 0/4] Add a libvirt backend to libguestfs.

2012-07-21 Thread Richard W.M. Jones
This preliminary patch series adds a libvirt backend to libguestfs. It's for review only because although it launches the guest OK, there are some missing features that need to be implemented. The meat of the patch is in part 4/4. To save you the trouble of interpreting libxml2 fragments, an exam