Re: [libvirt] [PATCH v1 07/11] virStoragePoolObjListAdd: Separate out definition assignment

2019-08-20 Thread Michal Privoznik
On 8/19/19 6:08 PM, John Ferlan wrote: Was it intentional to swap the order? That's a good question. Honestly, I don't recall. I'll fix it in my local branch. It looks like we should set the new pool definition with the pool list locked so that virStoragePoolObjIsDuplicate() and virStorageP

Re: [libvirt] [PATCH v1 07/11] virStoragePoolObjListAdd: Separate out definition assignment

2019-08-19 Thread John Ferlan
On 5/24/19 10:35 AM, Michal Privoznik wrote: > Separate storage pool definition assignment into a function. > > Signed-off-by: Michal Privoznik > --- > src/conf/virstorageobj.c | 23 --- > 1 file changed, 16 insertions(+), 7 deletions(-) > > diff --git a/src/conf/virstora

Re: [libvirt] [PATCH v1 07/11] virStoragePoolObjListAdd: Separate out definition assignment

2019-08-19 Thread Ján Tomko
On Fri, May 24, 2019 at 04:35:43PM +0200, Michal Privoznik wrote: Separate storage pool definition assignment into a function. Signed-off-by: Michal Privoznik --- src/conf/virstorageobj.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) Reviewed-by: Ján Tomko J

[libvirt] [PATCH v1 07/11] virStoragePoolObjListAdd: Separate out definition assignment

2019-05-24 Thread Michal Privoznik
Separate storage pool definition assignment into a function. Signed-off-by: Michal Privoznik --- src/conf/virstorageobj.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 7515b5d107..2b9ad6fc98