Re: [libvirt] [PATCH v2] Allow to dynamically set the size of the debug buffer

2011-03-14 Thread Daniel Veillard
On Mon, Mar 14, 2011 at 09:34:12PM -0600, Eric Blake wrote: > On 03/09/2011 02:08 AM, Daniel Veillard wrote: > > Allow to dynamically set the size of the debug buffer > > > > This is the part allowing to dynamically resize the debug log > > buffer from it's default 64kB size. The buffer is now dyn

Re: [libvirt] [PATCH v2] Allow to dynamically set the size of the debug buffer

2011-03-14 Thread Eric Blake
On 03/14/2011 09:34 PM, Eric Blake wrote: >> @@ -43,6 +44,8 @@ >> #include "threads.h" >> #include "files.h" >> >> +#define VIR_FROM_THIS VIR_FROM_NONE > > 'make syntax-check' won't like you; you forgot to edit po/POTFILES.in. > Then again, I only see an addition of VIR_WARN0, and not any ad

Re: [libvirt] [PATCH v2] Allow to dynamically set the size of the debug buffer

2011-03-14 Thread Eric Blake
On 03/09/2011 02:08 AM, Daniel Veillard wrote: > Allow to dynamically set the size of the debug buffer > > This is the part allowing to dynamically resize the debug log > buffer from it's default 64kB size. The buffer is now dynamically > allocated. > It adds a new API virLogSetBufferSize() which

[libvirt] [PATCH v2] Allow to dynamically set the size of the debug buffer

2011-03-09 Thread Daniel Veillard
[ sending this by hand as git-send-email seems to have failed to send the patch ... weird Result: 250 2.0.0 p2979dJi005806 Message accepted for delivery (mbox) Adding cc: Daniel Veillard from line 'From: Daniel Veillard ' (mbox) Adding to: libvir-list@redhat.com from line 'To: libvir-

[libvirt] [PATCH v2] Allow to dynamically set the size of the debug buffer

2011-03-08 Thread Daniel Veillard
Changes in v2: - fixes based on comment received (except using size_t for the reason provided) - avoid a deadlock in case of error allocating the buffer - make more clear that 64 kB is the default and any value <= 0 deactivate the buffer This is the part allowing to dynamicall