Re: [libvirt] [PATCH v2] Use virGetLastErrorMessage() rather than open code it

2016-04-11 Thread Cole Robinson
On 04/10/2016 10:40 PM, 惠轶群 wrote: > 2016-04-08 23:12 GMT+08:00 Cole Robinson : >> When sending a v2, please give a description of what changed compared to the >> previous patch version, after the --- break so it doesn't show up in the >> commit message. For example: > > Nice proposal. Thanks. >>

Re: [libvirt] [PATCH v2] Use virGetLastErrorMessage() rather than open code it

2016-04-10 Thread 惠轶群
2016-04-08 23:12 GMT+08:00 Cole Robinson : > When sending a v2, please give a description of what changed compared to the > previous patch version, after the --- break so it doesn't show up in the > commit message. For example: Nice proposal. Thanks. > > On 04/04/2016 06:49 AM, Hui Yiqun wrote: >>

Re: [libvirt] [PATCH v2] Use virGetLastErrorMessage() rather than open code it

2016-04-08 Thread Cole Robinson
When sending a v2, please give a description of what changed compared to the previous patch version, after the --- break so it doesn't show up in the commit message. For example: On 04/04/2016 06:49 AM, Hui Yiqun wrote: > getting err using virGetLastError() and then retrieving > message from err a

[libvirt] [PATCH v2] Use virGetLastErrorMessage() rather than open code it

2016-04-04 Thread Hui Yiqun
getting err using virGetLastError() and then retrieving message from err asks developers to test the value of err and err->message and default to self-defined unkown error message. It's better to avoid it and use uniform virGetLastErrorMessage --- daemon/libvirtd.c | 8 +--- ex