Re: [libvirt] [PATCH v2] bandwidth: Adjust documentation

2014-02-20 Thread Laine Stump
On 02/18/2014 07:16 PM, John Ferlan wrote: > Because I know it's easier to read without all the git +/-, here's what > I have now in the QoS section on the formatnetwork (hopefully I've > captured everything correctly): This all looks fine. ACK. > > > The element allows setting quality of servi

Re: [libvirt] [PATCH v2] bandwidth: Adjust documentation

2014-02-18 Thread John Ferlan
On 02/18/2014 05:58 AM, Laine Stump wrote: > On 02/17/2014 05:45 PM, John Ferlan wrote: >> >> Setting VLAN tag (on supported network types only) diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index 1ca1bec..d4c390a 100644 --- a/docs/formatnetw

Re: [libvirt] [PATCH v2] bandwidth: Adjust documentation

2014-02-18 Thread Laine Stump
On 02/17/2014 05:45 PM, John Ferlan wrote: > > >>> Setting VLAN tag (on supported network >>> types only) >>> diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in >>> index 1ca1bec..d4c390a 100644 >>> --- a/docs/formatnetwork.html.in >>> +++ b/docs/formatnetwork.html.in >>> @

Re: [libvirt] [PATCH v2] bandwidth: Adjust documentation

2014-02-17 Thread John Ferlan
>> >> Setting VLAN tag (on supported network >> types only) >> diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in >> index 1ca1bec..d4c390a 100644 >> --- a/docs/formatnetwork.html.in >> +++ b/docs/formatnetwork.html.in >> @@ -412,40 +412,81 @@ >> >> >>

Re: [libvirt] [PATCH v2] bandwidth: Adjust documentation

2014-02-17 Thread Michal Privoznik
On 13.02.2014 19:33, John Ferlan wrote: Recent autotest/virt-test testing on f20 discovered an anomaly in how the bandwidth options are documented and used. This was discovered due to a bug fix in the /sbin/tc utility found in iproute-3.11.0.1 (on f20) in which overflow was actually caught and re

[libvirt] [PATCH v2] bandwidth: Adjust documentation

2014-02-13 Thread John Ferlan
Recent autotest/virt-test testing on f20 discovered an anomaly in how the bandwidth options are documented and used. This was discovered due to a bug fix in the /sbin/tc utility found in iproute-3.11.0.1 (on f20) in which overflow was actually caught and returned as an error. The fix was first intr