Re: [libvirt] [PATCH v2] qemu: Fix domxml-to-native network model conversion

2012-10-27 Thread Cole Robinson
On 10/25/2012 06:12 PM, Peter Krempa wrote: > On 10/21/12 22:46, Cole Robinson wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=636832 >> --- >> >> v2: >> Don't needlessly reallocate model >> >> src/qemu/qemu_driver.c | 4 >> 1 file changed, 4 insertions(+) >> > > ACK, you resolv

Re: [libvirt] [PATCH v2] qemu: Fix domxml-to-native network model conversion

2012-10-25 Thread Peter Krempa
On 10/21/12 22:46, Cole Robinson wrote: https://bugzilla.redhat.com/show_bug.cgi?id=636832 --- v2: Don't needlessly reallocate model src/qemu/qemu_driver.c | 4 1 file changed, 4 insertions(+) ACK, you resolved what I pointed out in the review of v1. Peter -- libvir-list maili

Re: [libvirt] [PATCH v2] qemu: Fix domxml-to-native network model conversion

2012-10-25 Thread Cole Robinson
On 10/21/2012 04:46 PM, Cole Robinson wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=636832 > --- > > v2: > Don't needlessly reallocate model > > src/qemu/qemu_driver.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index

[libvirt] [PATCH v2] qemu: Fix domxml-to-native network model conversion

2012-10-21 Thread Cole Robinson
https://bugzilla.redhat.com/show_bug.cgi?id=636832 --- v2: Don't needlessly reallocate model src/qemu/qemu_driver.c | 4 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index feda4d9..7c462a2 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qem