Re: [libvirt] [PATCH v2] qemu: command: align disk serial check to schema

2017-08-23 Thread Nikolay Shirokovskiy
On 03.08.2017 02:24, John Ferlan wrote: > > > On 03/28/2017 04:10 AM, Nikolay Shirokovskiy wrote: >> Disk serial schema has extra '.+' allowed characters in comparison >> with check in code. Looks like there is no reason for that as qemu >> allows any character AFAIK for serial. This discrepanc

Re: [libvirt] [PATCH v2] qemu: command: align disk serial check to schema

2017-08-02 Thread John Ferlan
On 03/28/2017 04:10 AM, Nikolay Shirokovskiy wrote: > Disk serial schema has extra '.+' allowed characters in comparison > with check in code. Looks like there is no reason for that as qemu > allows any character AFAIK for serial. This discrepancy is originated > in 85d15b51 where ability to add

Re: [libvirt] [PATCH v2] qemu: command: align disk serial check to schema

2017-04-12 Thread Nikolay Shirokovskiy
ping On 28.03.2017 11:10, Nikolay Shirokovskiy wrote: > Disk serial schema has extra '.+' allowed characters in comparison > with check in code. Looks like there is no reason for that as qemu > allows any character AFAIK for serial. This discrepancy is originated > in 85d15b51 where ability to add

[libvirt] [PATCH v2] qemu: command: align disk serial check to schema

2017-03-28 Thread Nikolay Shirokovskiy
Disk serial schema has extra '.+' allowed characters in comparison with check in code. Looks like there is no reason for that as qemu allows any character AFAIK for serial. This discrepancy is originated in 85d15b51 where ability to add serial was added. --- Diff from v1: * fix xml2argv disk seri