Re: [libvirt] [PATCH v2] snapshot: Don't hose list on deletion failure

2018-11-06 Thread Michal Privoznik
On 10/18/2018 03:45 AM, Eric Blake wrote: > If qemuDomainSnapshotDiscard() fails for any reason (rare, > but possible with an ill-timed ENOMEM or if > qemuDomainSnapshotForEachQcow2() has problems talking to the > qemu guest monitor), then an attempt to retry the snapshot > deletion API will crash

Re: [libvirt] [PATCH v2] snapshot: Don't hose list on deletion failure

2018-11-05 Thread Eric Blake
ping On 10/17/18 8:45 PM, Eric Blake wrote: If qemuDomainSnapshotDiscard() fails for any reason (rare, but possible with an ill-timed ENOMEM or if qemuDomainSnapshotForEachQcow2() has problems talking to the qemu guest monitor), then an attempt to retry the snapshot deletion API will crash becau

[libvirt] [PATCH v2] snapshot: Don't hose list on deletion failure

2018-10-17 Thread Eric Blake
If qemuDomainSnapshotDiscard() fails for any reason (rare, but possible with an ill-timed ENOMEM or if qemuDomainSnapshotForEachQcow2() has problems talking to the qemu guest monitor), then an attempt to retry the snapshot deletion API will crash because we didn't undo the effects of virDomainSnaps