Re: [libvirt] [PATCH v2] util: audit: Fix logging an error when kernel lacks audit support

2019-01-16 Thread Erik Skultety
On Wed, Jan 16, 2019 at 03:45:06PM +, Daniel P. Berrangé wrote: > On Wed, Jan 16, 2019 at 03:58:24PM +0100, Erik Skultety wrote: > > Based on an upstream discussion, reporting the errno is useful for the > > user to know why audit isn't supported. Even though having an error in > > the logs mig

Re: [libvirt] [PATCH v2] util: audit: Fix logging an error when kernel lacks audit support

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 03:58:24PM +0100, Erik Skultety wrote: > Based on an upstream discussion, reporting the errno is useful for the > user to know why audit isn't supported. Even though having an error in > the logs might look concerning when 'audit_log=1', it also denotes that > audit is only

[libvirt] [PATCH v2] util: audit: Fix logging an error when kernel lacks audit support

2019-01-16 Thread Erik Skultety
Based on an upstream discussion, reporting the errno is useful for the user to know why audit isn't supported. Even though having an error in the logs might look concerning when 'audit_log=1', it also denotes that audit is only going to be used if it's available, continuing normally if it's unavail