Re: [libvirt] [PATCH v2] virsh: Correctly initialize libvirt

2011-05-17 Thread Jiri Denemark
On Mon, May 16, 2011 at 09:05:36 -0600, Eric Blake wrote: > On 05/16/2011 08:59 AM, Jiri Denemark wrote: > > virsh didn't call virInitialize(), which (among other things) > > initializes virLastErr thread local variable. As a result of that, virsh > > could just segfault in virEventRegisterDefaultI

Re: [libvirt] [PATCH v2] virsh: Correctly initialize libvirt

2011-05-16 Thread Eric Blake
On 05/16/2011 08:59 AM, Jiri Denemark wrote: > virsh didn't call virInitialize(), which (among other things) > initializes virLastErr thread local variable. As a result of that, virsh > could just segfault in virEventRegisterDefaultImpl() since that is the > first call that touches (resets) virLast

[libvirt] [PATCH v2] virsh: Correctly initialize libvirt

2011-05-16 Thread Jiri Denemark
virsh didn't call virInitialize(), which (among other things) initializes virLastErr thread local variable. As a result of that, virsh could just segfault in virEventRegisterDefaultImpl() since that is the first call that touches (resets) virLastErr. I have no idea what lucky coincidence made this