Re: [libvirt] [PATCH v2 03/10] conf: Introduce scsi hostdev

2013-04-05 Thread Osier Yang
On 05/04/13 16:33, Daniel P. Berrange wrote: On Fri, Apr 05, 2013 at 01:00:00PM +0800, Han Cheng wrote: On 04/02/2013 11:19 AM, Hu Tao wrote: On Mon, Apr 01, 2013 at 08:00:55PM +0800, Han Cheng wrote: diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c index a776058..2fb5989 100644

Re: [libvirt] [PATCH v2 03/10] conf: Introduce scsi hostdev

2013-04-05 Thread Daniel P. Berrange
On Fri, Apr 05, 2013 at 01:00:00PM +0800, Han Cheng wrote: > On 04/02/2013 11:19 AM, Hu Tao wrote: > >On Mon, Apr 01, 2013 at 08:00:55PM +0800, Han Cheng wrote: > >>diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c > >>index a776058..2fb5989 100644 > >>--- a/src/conf/domain_audit.c > >

Re: [libvirt] [PATCH v2 03/10] conf: Introduce scsi hostdev

2013-04-04 Thread Han Cheng
On 04/03/2013 04:32 PM, Osier Yang wrote: On 03/04/13 16:29, Osier Yang wrote: On 01/04/13 20:00, Han Cheng wrote: hostdev The hostdev element is the main container for describing host devices. For usb device passthrough mode is always - "subsystem" and type is "usb" for a USB device and "pci

Re: [libvirt] [PATCH v2 03/10] conf: Introduce scsi hostdev

2013-04-04 Thread Han Cheng
On 04/02/2013 11:19 AM, Hu Tao wrote: On Mon, Apr 01, 2013 at 08:00:55PM +0800, Han Cheng wrote: diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c index a776058..2fb5989 100644 --- a/src/conf/domain_audit.c +++ b/src/conf/domain_audit.c @@ -398,6 +398,16 @@ virDomainAuditHostdev(vir

Re: [libvirt] [PATCH v2 03/10] conf: Introduce scsi hostdev

2013-04-03 Thread Han Cheng
On 04/03/2013 04:29 PM, Osier Yang wrote: On 01/04/13 20:00, Han Cheng wrote: @@ -10773,6 +10911,16 @@ virDomainDefParseXML(virCapsPtr caps, goto error; } + if (hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI && + hostdev->info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) { +

Re: [libvirt] [PATCH v2 03/10] conf: Introduce scsi hostdev

2013-04-03 Thread Osier Yang
On 03/04/13 16:29, Osier Yang wrote: On 01/04/13 20:00, Han Cheng wrote: Adding scsi hostdev, it should like: s/Adding/Add, s/should/looks/, unit='8'/> Signed-off-by: Han Cheng --- docs/formatdomain.html.in | 34 ++-- do

Re: [libvirt] [PATCH v2 03/10] conf: Introduce scsi hostdev

2013-04-03 Thread Osier Yang
On 01/04/13 20:00, Han Cheng wrote: Adding scsi hostdev, it should like: s/Adding/Add, s/should/looks/, Signed-off-by: Han Cheng --- docs/formatdomain.html.in | 34 ++-- docs/schemas/domaincommon.rng | 24 + src/co

Re: [libvirt] [PATCH v2 03/10] conf: Introduce scsi hostdev

2013-04-01 Thread Hu Tao
On Mon, Apr 01, 2013 at 08:00:55PM +0800, Han Cheng wrote: > Adding scsi hostdev, it should like: > > > > > > > > > > Signed-off-by: Han Cheng > --- > docs/formatdomain.html.in | 34 ++-- > docs/schemas/domaincommon.rng | 24 + >

[libvirt] [PATCH v2 03/10] conf: Introduce scsi hostdev

2013-04-01 Thread Han Cheng
Adding scsi hostdev, it should like: Signed-off-by: Han Cheng --- docs/formatdomain.html.in | 34 ++-- docs/schemas/domaincommon.rng | 24 + src/conf/domain_audit.c | 10 ++ src/conf/domain_conf.c| 192 +++