Re: [libvirt] [PATCH v2 04/15] virDomainLoaderDefParseXML: Allow loader path to be NULL

2019-03-12 Thread Laszlo Ersek
On 03/07/19 10:29, Michal Privoznik wrote: > Except not really. At least for now. > > In the future, the firmware will be selected automagically. > Therefore, it makes no sense to require the pathname of a > specific firmware binary in the domain XML. But since it is not > implemented do not reall

Re: [libvirt] [PATCH v2 04/15] virDomainLoaderDefParseXML: Allow loader path to be NULL

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 10:29:14AM +0100, Michal Privoznik wrote: > Except not really. At least for now. > > In the future, the firmware will be selected automagically. > Therefore, it makes no sense to require the pathname of a > specific firmware binary in the domain XML. But since it is not > i

[libvirt] [PATCH v2 04/15] virDomainLoaderDefParseXML: Allow loader path to be NULL

2019-03-07 Thread Michal Privoznik
Except not really. At least for now. In the future, the firmware will be selected automagically. Therefore, it makes no sense to require the pathname of a specific firmware binary in the domain XML. But since it is not implemented do not really allow the path to be NULL. Only move code around to p