Re: [libvirt] [PATCH v2 1/2] conf: add debugcon chardev guest interface

2019-02-12 Thread Nikolay Shirokovskiy
On 11.02.2019 16:40, Andrea Bolognani wrote: > On Mon, 2019-02-11 at 08:14 +, Nikolay Shirokovskiy wrote: >> On 08.02.2019 17:34, Andrea Bolognani wrote: >>> Even with that fixed, while your code prevents a element >>> associated to the isa-debugcon to be automatically created, it >>> doesn

Re: [libvirt] [PATCH v2 1/2] conf: add debugcon chardev guest interface

2019-02-11 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 02:40:55PM +0100, Andrea Bolognani wrote: > On Mon, 2019-02-11 at 08:14 +, Nikolay Shirokovskiy wrote: > > On 08.02.2019 17:34, Andrea Bolognani wrote: > > > Even with that fixed, while your code prevents a element > > > associated to the isa-debugcon to be automaticall

Re: [libvirt] [PATCH v2 1/2] conf: add debugcon chardev guest interface

2019-02-11 Thread Andrea Bolognani
On Mon, 2019-02-11 at 08:14 +, Nikolay Shirokovskiy wrote: > On 08.02.2019 17:34, Andrea Bolognani wrote: > > Even with that fixed, while your code prevents a element > > associated to the isa-debugcon to be automatically created, it > > doesn't prevent something like > > > > > > > >

Re: [libvirt] [PATCH v2 1/2] conf: add debugcon chardev guest interface

2019-02-11 Thread Nikolay Shirokovskiy
On 08.02.2019 17:34, Andrea Bolognani wrote: > On Thu, 2019-02-07 at 14:31 +0300, Nikolay Shirokovskiy wrote: > [...] >> @@ -4392,6 +4393,9 @@ virDomainDefAddConsoleCompat(virDomainDefPtr def) >> >> switch ((virDomainChrSerialTargetType) def->serials[0]->targetType) >> { >>

Re: [libvirt] [PATCH v2 1/2] conf: add debugcon chardev guest interface

2019-02-08 Thread Andrea Bolognani
On Thu, 2019-02-07 at 14:31 +0300, Nikolay Shirokovskiy wrote: [...] > @@ -4392,6 +4393,9 @@ virDomainDefAddConsoleCompat(virDomainDefPtr def) > > switch ((virDomainChrSerialTargetType) def->serials[0]->targetType) { > case VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_ISA: > +i

[libvirt] [PATCH v2 1/2] conf: add debugcon chardev guest interface

2019-02-07 Thread Nikolay Shirokovskiy
This interface can be used for example by firmware to print debug messages. Here is domain xml example: Add checks to make sure this new serial type won't be reported as back-compat console. Signed-off-by: Nikolay Shirokovskiy --- docs/formatdomain.html.