Re: [libvirt] [PATCH v2 1/5] Extend XML parser and generator to support comment attribute

2010-09-28 Thread Stefan Berger
Eric Blake wrote on 09/28/2010 03:19:42 PM: > > On 09/27/2010 02:26 PM, Stefan Berger wrote: > >>> The patch below extends the XML parser and generator so that every > > protocol > >>> now can have a comment node. Comments are limited to 256 characters > > and are > >>> tested to only contain p

Re: [libvirt] [PATCH v2 1/5] Extend XML parser and generator to support comment attribute

2010-09-28 Thread Eric Blake
On 09/27/2010 02:26 PM, Stefan Berger wrote: The patch below extends the XML parser and generator so that every protocol now can have a comment node. Comments are limited to 256 characters and are tested to only contain printable characters or spaces. Literal spaces, or generic blanks (spac

Re: [libvirt] [PATCH v2 1/5] Extend XML parser and generator to support comment attribute

2010-09-27 Thread Stefan Berger
Eric Blake wrote on 09/27/2010 04:02:54 PM: > > On 09/27/2010 12:40 PM, Stefan Berger wrote: > > V2: > > - introducing a field 'maxstrlen' to control the length of accepted string > > - removed function validating comment string assuming the XML parser > > already sinity checked the st

Re: [libvirt] [PATCH v2 1/5] Extend XML parser and generator to support comment attribute

2010-09-27 Thread Eric Blake
On 09/27/2010 12:40 PM, Stefan Berger wrote: V2: - introducing a field 'maxstrlen' to control the length of accepted string - removed function validating comment string assuming the XML parser already sinity checked the string s/sinity/sanity/, if you leave this in your commit message

[libvirt] [PATCH v2 1/5] Extend XML parser and generator to support comment attribute

2010-09-27 Thread Stefan Berger
V2: - introducing a field 'maxstrlen' to control the length of accepted string - removed function validating comment string assuming the XML parser already sinity checked the string The patch below extends the XML parser and generator so that every protocol now can have a comment node. Com