Re: [libvirt] [PATCH v2 1/6] tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases

2016-02-10 Thread Andrea Bolognani
On Wed, 2016-02-10 at 11:21 +0100, Martin Kletzander wrote: > > > > > Why did I think that we had eliminated all use of "-usb"? Is it that > > > > > we're > > > > > currently only using it in the tests? If so, that's another thing to > > > > > eliminate > > > > > - we should never be using -usb u

Re: [libvirt] [PATCH v2 1/6] tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases

2016-02-10 Thread Martin Kletzander
On Tue, Feb 09, 2016 at 02:42:53PM -0500, Cole Robinson wrote: On 02/09/2016 02:28 PM, Laine Stump wrote: On 02/09/2016 01:46 PM, Cole Robinson wrote: On 02/09/2016 01:31 PM, Laine Stump wrote: On 02/09/2016 10:58 AM, Cole Robinson wrote: When we unconditionally enable QEMU_CAPS_DEVICE, these

Re: [libvirt] [PATCH v2 1/6] tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases

2016-02-09 Thread Cole Robinson
On 02/09/2016 02:28 PM, Laine Stump wrote: > On 02/09/2016 01:46 PM, Cole Robinson wrote: >> On 02/09/2016 01:31 PM, Laine Stump wrote: >>> On 02/09/2016 10:58 AM, Cole Robinson wrote: When we unconditionally enable QEMU_CAPS_DEVICE, these tests need some massaging, so do it ahead of time

Re: [libvirt] [PATCH v2 1/6] tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases

2016-02-09 Thread Laine Stump
On 02/09/2016 01:46 PM, Cole Robinson wrote: On 02/09/2016 01:31 PM, Laine Stump wrote: On 02/09/2016 10:58 AM, Cole Robinson wrote: When we unconditionally enable QEMU_CAPS_DEVICE, these tests need some massaging, so do it ahead of time to not mix it in with the big test refresh. - minimal-s3

Re: [libvirt] [PATCH v2 1/6] tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases

2016-02-09 Thread Cole Robinson
On 02/09/2016 01:31 PM, Laine Stump wrote: > On 02/09/2016 10:58 AM, Cole Robinson wrote: >> When we unconditionally enable QEMU_CAPS_DEVICE, these tests need >> some massaging, so do it ahead of time to not mix it in with the >> big test refresh. >> >> - minimal-s390 is not a real world working co

Re: [libvirt] [PATCH v2 1/6] tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases

2016-02-09 Thread Laine Stump
On 02/09/2016 10:58 AM, Cole Robinson wrote: When we unconditionally enable QEMU_CAPS_DEVICE, these tests need some massaging, so do it ahead of time to not mix it in with the big test refresh. - minimal-s390 is not a real world working config, so drop it - disk-usb was testing for an old code p

[libvirt] [PATCH v2 1/6] tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases

2016-02-09 Thread Cole Robinson
When we unconditionally enable QEMU_CAPS_DEVICE, these tests need some massaging, so do it ahead of time to not mix it in with the big test refresh. - minimal-s390 is not a real world working config, so drop it - disk-usb was testing for an old code path that will be removed. instead use it to t