Re: [libvirt] [PATCH v2 1/8] hellolibvirt: Update hellolibvirt example

2013-02-24 Thread Laine Stump
On 02/22/2013 07:46 AM, John Ferlan wrote: > On 02/20/2013 08:05 PM, Dave Allan wrote: >> On Wed, Feb 20, 2013 at 12:38:38PM -0500, John Ferlan wrote: >>> Update the code to be more in line with how code looks elsewhere in >>> libvirt. Allow listing of domains, networks, storage pools, and >>> net

Re: [libvirt] [PATCH v2 1/8] hellolibvirt: Update hellolibvirt example

2013-02-22 Thread John Ferlan
On 02/20/2013 08:05 PM, Dave Allan wrote: > On Wed, Feb 20, 2013 at 12:38:38PM -0500, John Ferlan wrote: >> Update the code to be more in line with how code looks elsewhere in >> libvirt. Allow listing of domains, networks, storage pools, and >> network interfaces. > > I like the changes to make

Re: [libvirt] [PATCH v2 1/8] hellolibvirt: Update hellolibvirt example

2013-02-20 Thread Dave Allan
On Wed, Feb 20, 2013 at 12:38:38PM -0500, John Ferlan wrote: > Update the code to be more in line with how code looks elsewhere in > libvirt. Allow listing of domains, networks, storage pools, and > network interfaces. I like the changes to make the style more in line with the rest of the codebas

[libvirt] [PATCH v2 1/8] hellolibvirt: Update hellolibvirt example

2013-02-20 Thread John Ferlan
Update the code to be more in line with how code looks elsewhere in libvirt. Allow listing of domains, networks, storage pools, and network interfaces. Update the function prototypes in libvirt.c to include a message about the client needing to free() returned name fields. Fix the all domains ex