Re: [libvirt] [PATCH v2 11/32] storage: Use VIR_AUTOPTR(virCommand)

2019-02-11 Thread Ján Tomko
On Mon, Feb 11, 2019 at 09:33:53PM -0500, John Ferlan wrote: On 2/11/19 9:52 AM, Ján Tomko wrote: On Mon, Feb 11, 2019 at 07:41:41AM -0500, John Ferlan wrote: On 2/11/19 7:33 AM, Ján Tomko wrote: On Fri, Feb 08, 2019 at 01:37:05PM -0500, John Ferlan wrote: Let's make use of the auto __cle

Re: [libvirt] [PATCH v2 11/32] storage: Use VIR_AUTOPTR(virCommand)

2019-02-11 Thread John Ferlan
On 2/11/19 9:52 AM, Ján Tomko wrote: > On Mon, Feb 11, 2019 at 07:41:41AM -0500, John Ferlan wrote: >> >> >> On 2/11/19 7:33 AM, Ján Tomko wrote: >>> On Fri, Feb 08, 2019 at 01:37:05PM -0500, John Ferlan wrote: Let's make use of the auto __cleanup capabilities cleaning up any now unnece

Re: [libvirt] [PATCH v2 11/32] storage: Use VIR_AUTOPTR(virCommand)

2019-02-11 Thread Ján Tomko
On Mon, Feb 11, 2019 at 07:41:41AM -0500, John Ferlan wrote: On 2/11/19 7:33 AM, Ján Tomko wrote: On Fri, Feb 08, 2019 at 01:37:05PM -0500, John Ferlan wrote: Let's make use of the auto __cleanup capabilities cleaning up any now unnecessary goto paths. Signed-off-by: John Ferlan Reviewed-by

Re: [libvirt] [PATCH v2 11/32] storage: Use VIR_AUTOPTR(virCommand)

2019-02-11 Thread John Ferlan
On 2/11/19 7:33 AM, Ján Tomko wrote: > On Fri, Feb 08, 2019 at 01:37:05PM -0500, John Ferlan wrote: >> Let's make use of the auto __cleanup capabilities cleaning up any >> now unnecessary goto paths. >> >> Signed-off-by: John Ferlan >> Reviewed-by: Erik Skultety >> --- >> src/storage/storage_b

Re: [libvirt] [PATCH v2 11/32] storage: Use VIR_AUTOPTR(virCommand)

2019-02-11 Thread Ján Tomko
On Fri, Feb 08, 2019 at 01:37:05PM -0500, John Ferlan wrote: Let's make use of the auto __cleanup capabilities cleaning up any now unnecessary goto paths. Signed-off-by: John Ferlan Reviewed-by: Erik Skultety --- src/storage/storage_backend_disk.c | 85 + src/storage/st

[libvirt] [PATCH v2 11/32] storage: Use VIR_AUTOPTR(virCommand)

2019-02-08 Thread John Ferlan
Let's make use of the auto __cleanup capabilities cleaning up any now unnecessary goto paths. Signed-off-by: John Ferlan Reviewed-by: Erik Skultety --- src/storage/storage_backend_disk.c | 85 + src/storage/storage_backend_fs.c | 39 +++--- src/storage/storag