Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-05-15 Thread Michal Privoznik
On 05/15/2017 10:56 AM, Daniel P. Berrange wrote: > On Mon, May 15, 2017 at 10:54:03AM +0200, Michal Privoznik wrote: > >> Now, question is whether we want signed or unsigned long long. I don't >> have an opinion about that. On one hand, off_t is signed, but that's >> because lseek() can seek bac

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-05-15 Thread Daniel P. Berrange
On Mon, May 15, 2017 at 10:54:03AM +0200, Michal Privoznik wrote: > On 05/15/2017 10:25 AM, Daniel P. Berrange wrote: > > On Fri, May 12, 2017 at 09:29:27AM +0200, Michal Privoznik wrote: > >> On 05/05/2017 04:48 PM, Daniel P. Berrange wrote: > >>> On Fri, May 05, 2017 at 01:25:34PM +0200, Michal P

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-05-15 Thread Michal Privoznik
On 05/15/2017 10:25 AM, Daniel P. Berrange wrote: > On Fri, May 12, 2017 at 09:29:27AM +0200, Michal Privoznik wrote: >> On 05/05/2017 04:48 PM, Daniel P. Berrange wrote: >>> On Fri, May 05, 2017 at 01:25:34PM +0200, Michal Privoznik wrote: On 05/04/2017 11:29 PM, John Ferlan wrote: >

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-05-15 Thread Daniel P. Berrange
On Fri, May 12, 2017 at 09:29:27AM +0200, Michal Privoznik wrote: > On 05/05/2017 04:48 PM, Daniel P. Berrange wrote: > > On Fri, May 05, 2017 at 01:25:34PM +0200, Michal Privoznik wrote: > >> On 05/04/2017 11:29 PM, John Ferlan wrote: > >>> > >>> > >>> On 04/20/2017 06:01 AM, Michal Privoznik wrot

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-05-12 Thread Michal Privoznik
On 05/12/2017 12:56 PM, John Ferlan wrote: > > > On 05/12/2017 03:29 AM, Michal Privoznik wrote: >> On 05/05/2017 04:48 PM, Daniel P. Berrange wrote: >>> On Fri, May 05, 2017 at 01:25:34PM +0200, Michal Privoznik wrote: On 05/04/2017 11:29 PM, John Ferlan wrote: > > > On 04/20/20

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-05-12 Thread John Ferlan
On 05/12/2017 03:29 AM, Michal Privoznik wrote: > On 05/05/2017 04:48 PM, Daniel P. Berrange wrote: >> On Fri, May 05, 2017 at 01:25:34PM +0200, Michal Privoznik wrote: >>> On 05/04/2017 11:29 PM, John Ferlan wrote: On 04/20/2017 06:01 AM, Michal Privoznik wrote: > This API can

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-05-12 Thread Michal Privoznik
On 05/05/2017 04:48 PM, Daniel P. Berrange wrote: > On Fri, May 05, 2017 at 01:25:34PM +0200, Michal Privoznik wrote: >> On 05/04/2017 11:29 PM, John Ferlan wrote: >>> >>> >>> On 04/20/2017 06:01 AM, Michal Privoznik wrote: This API can be used to tell the other side of the stream to skip >>>

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-05-05 Thread Daniel P. Berrange
On Fri, May 05, 2017 at 01:25:34PM +0200, Michal Privoznik wrote: > On 05/04/2017 11:29 PM, John Ferlan wrote: > > > > > > On 04/20/2017 06:01 AM, Michal Privoznik wrote: > >> This API can be used to tell the other side of the stream to skip > > > > s/can be/is (unless it can be used for someth

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-05-05 Thread John Ferlan
On 05/05/2017 07:25 AM, Michal Privoznik wrote: > On 05/04/2017 11:29 PM, John Ferlan wrote: >> >> >> On 04/20/2017 06:01 AM, Michal Privoznik wrote: >>> This API can be used to tell the other side of the stream to skip >> >> s/can be/is (unless it can be used for something else ;-)) >> >>> some

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-05-05 Thread Michal Privoznik
On 05/04/2017 11:29 PM, John Ferlan wrote: > > > On 04/20/2017 06:01 AM, Michal Privoznik wrote: >> This API can be used to tell the other side of the stream to skip > > s/can be/is (unless it can be used for something else ;-)) > >> some bytes in the stream. This can be used to create a spars

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-05-04 Thread John Ferlan
On 04/20/2017 06:01 AM, Michal Privoznik wrote: > This API can be used to tell the other side of the stream to skip s/can be/is (unless it can be used for something else ;-)) > some bytes in the stream. This can be used to create a sparse > file on the receiving side of a stream. > > It takes

[libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-04-20 Thread Michal Privoznik
This API can be used to tell the other side of the stream to skip some bytes in the stream. This can be used to create a sparse file on the receiving side of a stream. It takes just one argument @length, which says how big the hole is. Since our streams are not rewindable like regular files, we do