Re: [libvirt] [PATCH v2 2/2] qemu: implement debugcon-isa chardev

2019-02-12 Thread Ján Tomko
On Fri, Feb 08, 2019 at 04:02:38PM +0100, Andrea Bolognani wrote: On Thu, 2019-02-07 at 14:31 +0300, Nikolay Shirokovskiy wrote: +++ b/tests/qemuxml2argvtest.c @@ -1490,6 +1490,7 @@ mymain(void) QEMU_CAPS_DEVICE_ISA_SERIAL); DO_TEST("pci-serial-dev-chardev", QEMU_C

Re: [libvirt] [PATCH v2 2/2] qemu: implement debugcon-isa chardev

2019-02-12 Thread Ján Tomko
On Mon, Feb 11, 2019 at 06:23:32PM +0100, Andrea Bolognani wrote: On Mon, 2019-02-11 at 08:53 +, Nikolay Shirokovskiy wrote: On 08.02.2019 18:02, Andrea Bolognani wrote: > On Thu, 2019-02-07 at 14:31 +0300, Nikolay Shirokovskiy wrote: > [...] > > @@ -393,9 +393,11 @@ qemuBuildDeviceAddressSt

Re: [libvirt] [PATCH v2 2/2] qemu: implement debugcon-isa chardev

2019-02-12 Thread Nikolay Shirokovskiy
On 11.02.2019 20:23, Andrea Bolognani wrote: > On Mon, 2019-02-11 at 08:53 +, Nikolay Shirokovskiy wrote: >> On 08.02.2019 18:02, Andrea Bolognani wrote: >>> On Thu, 2019-02-07 at 14:31 +0300, Nikolay Shirokovskiy wrote: >>> [...] @@ -393,9 +393,11 @@ qemuBuildDeviceAddressStr(virBuffer

Re: [libvirt] [PATCH v2 2/2] qemu: implement debugcon-isa chardev

2019-02-11 Thread Andrea Bolognani
On Mon, 2019-02-11 at 08:53 +, Nikolay Shirokovskiy wrote: > On 08.02.2019 18:02, Andrea Bolognani wrote: > > On Thu, 2019-02-07 at 14:31 +0300, Nikolay Shirokovskiy wrote: > > [...] > > > @@ -393,9 +393,11 @@ qemuBuildDeviceAddressStr(virBufferPtr buf, > > >info

Re: [libvirt] [PATCH v2 2/2] qemu: implement debugcon-isa chardev

2019-02-11 Thread Nikolay Shirokovskiy
On 08.02.2019 18:02, Andrea Bolognani wrote: > On Thu, 2019-02-07 at 14:31 +0300, Nikolay Shirokovskiy wrote: > [...] >> @@ -393,9 +393,11 @@ qemuBuildDeviceAddressStr(virBufferPtr buf, >>info->addr.ccw.ssid, >>info->addr.ccw.devno)

Re: [libvirt] [PATCH v2 2/2] qemu: implement debugcon-isa chardev

2019-02-08 Thread Andrea Bolognani
On Thu, 2019-02-07 at 14:31 +0300, Nikolay Shirokovskiy wrote: [...] > @@ -393,9 +393,11 @@ qemuBuildDeviceAddressStr(virBufferPtr buf, >info->addr.ccw.ssid, >info->addr.ccw.devno); > } else if (info->type == VIR_DOMAIN_DEVICE_ADD

[libvirt] [PATCH v2 2/2] qemu: implement debugcon-isa chardev

2019-02-07 Thread Nikolay Shirokovskiy
Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_command.c | 8 --- tests/qemuxml2argvdata/isa-serial-debugcon.args | 29 + tests/qemuxml2argvtest.c| 1 + 3 files changed, 35 insertions(+), 3 deletions(-) create m