Re: [libvirt] [PATCH v2 2/2] qemu: parse: Handle suffixes for -m memory

2016-05-19 Thread Nishith Shah
On Thu, May 19, 2016 at 5:40 PM, Cole Robinson wrote: > On 05/18/2016 02:36 AM, Nishith Shah wrote: > > diff --git a/src/qemu/qemu_parse_command.c > b/src/qemu/qemu_parse_command.c > > index 334dcf8..f027d51 100644 > > --- a/src/qemu/qemu_parse_command.c > > +++ b/src/qemu/qemu_parse_command.c >

Re: [libvirt] [PATCH v2 2/2] qemu: parse: Handle suffixes for -m memory

2016-05-19 Thread Cole Robinson
On 05/18/2016 02:36 AM, Nishith Shah wrote: > According to QEMU docs, the '-m' option for specifying RAM is by default > in MiB, and a suffix of "M" or "G" may be passed for values in MiB and > GiB respectively. This commit adds support and a test for the same. > > Resolves: https://bugzilla.redha

[libvirt] [PATCH v2 2/2] qemu: parse: Handle suffixes for -m memory

2016-05-17 Thread Nishith Shah
According to QEMU docs, the '-m' option for specifying RAM is by default in MiB, and a suffix of "M" or "G" may be passed for values in MiB and GiB respectively. This commit adds support and a test for the same. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=812295 Signed-off-by: Nishith S