Re: [libvirt] [PATCH v2 3/5] conf: Make virNetworkIPDefParseXML a little bit saner

2016-12-16 Thread Laine Stump
On 12/16/2016 11:39 AM, Jiri Denemark wrote: On Wed, Dec 14, 2016 at 10:46:20 -0500, Laine Stump wrote: On 12/13/2016 08:52 AM, Jiri Denemark wrote: Iterating over all child nodes when we only support one instance of each child is pretty weired. And it would even cause memory leaks if more than

Re: [libvirt] [PATCH v2 3/5] conf: Make virNetworkIPDefParseXML a little bit saner

2016-12-16 Thread Jiri Denemark
On Wed, Dec 14, 2016 at 10:46:20 -0500, Laine Stump wrote: > On 12/13/2016 08:52 AM, Jiri Denemark wrote: > > Iterating over all child nodes when we only support one instance of each > > child is pretty weired. And it would even cause memory leaks if more > > than one element was specified. > > A

Re: [libvirt] [PATCH v2 3/5] conf: Make virNetworkIPDefParseXML a little bit saner

2016-12-14 Thread Laine Stump
On 12/13/2016 08:52 AM, Jiri Denemark wrote: Iterating over all child nodes when we only support one instance of each child is pretty weired. And it would even cause memory leaks if more than one element was specified. ACK, but could you also look for dhcp[2]/tftp[2] and log an error if found

[libvirt] [PATCH v2 3/5] conf: Make virNetworkIPDefParseXML a little bit saner

2016-12-13 Thread Jiri Denemark
Iterating over all child nodes when we only support one instance of each child is pretty weired. And it would even cause memory leaks if more than one element was specified. Signed-off-by: Jiri Denemark --- src/conf/network_conf.c | 36 ++-- 1 file changed, 14 in