Re: [libvirt] [PATCH v2 4/4] util: alloc: Note that VIR_AUTOPTR/VIR_AUTOCLEAN must not be used with vectors

2019-02-28 Thread Erik Skultety
On Thu, Feb 28, 2019 at 02:56:36PM +0100, Peter Krempa wrote: > On Wed, Feb 27, 2019 at 15:05:18 +0100, Erik Skultety wrote: > > On Tue, Feb 26, 2019 at 04:48:26PM +0100, Peter Krempa wrote: > > > We'd free only the first element of the vector leaking the rest. > > > > > > Signed-off-by: Peter Krem

Re: [libvirt] [PATCH v2 4/4] util: alloc: Note that VIR_AUTOPTR/VIR_AUTOCLEAN must not be used with vectors

2019-02-28 Thread Peter Krempa
On Wed, Feb 27, 2019 at 15:05:18 +0100, Erik Skultety wrote: > On Tue, Feb 26, 2019 at 04:48:26PM +0100, Peter Krempa wrote: > > We'd free only the first element of the vector leaking the rest. > > > > Signed-off-by: Peter Krempa > > --- > > src/util/viralloc.h | 6 ++ > > 1 file changed, 6 i

Re: [libvirt] [PATCH v2 4/4] util: alloc: Note that VIR_AUTOPTR/VIR_AUTOCLEAN must not be used with vectors

2019-02-27 Thread Erik Skultety
On Tue, Feb 26, 2019 at 04:48:26PM +0100, Peter Krempa wrote: > We'd free only the first element of the vector leaking the rest. > > Signed-off-by: Peter Krempa > --- > src/util/viralloc.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/util/viralloc.h b/src/util/viralloc.h > i

[libvirt] [PATCH v2 4/4] util: alloc: Note that VIR_AUTOPTR/VIR_AUTOCLEAN must not be used with vectors

2019-02-26 Thread Peter Krempa
We'd free only the first element of the vector leaking the rest. Signed-off-by: Peter Krempa --- src/util/viralloc.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/util/viralloc.h b/src/util/viralloc.h index 15451d4673..572b7d1c1c 100644 --- a/src/util/viralloc.h +++ b/src/util/vi