Re: [libvirt] [PATCH v2 4/5] In storageVolumeCreateXML, spawn a new thread for volbuilding, in storageVolumeDelete, generate the signal

2011-07-18 Thread Eric Blake
On 07/18/2011 05:13 AM, Guannan Ren wrote: Independantly of this, IMHO pthread cancellation handlers are a recipe for trouble because it is incredibly hard to make sure you correctly cleanup all resources in the thread, even with use of cleanup handlers. IMHO, threads should be made to monitor s

Re: [libvirt] [PATCH v2 4/5] In storageVolumeCreateXML, spawn a new thread for volbuilding, in storageVolumeDelete, generate the signal

2011-07-18 Thread Guannan Ren
On 07/18/2011 06:57 PM, Daniel P. Berrange wrote: On Sun, Jul 17, 2011 at 06:45:00PM +0800, Guannan Ren wrote: --- src/storage/storage_backend.c |9 src/storage/storage_driver.c | 83 - 2 files changed, 82 insertions(+), 10 deletions(-) di

Re: [libvirt] [PATCH v2 4/5] In storageVolumeCreateXML, spawn a new thread for volbuilding, in storageVolumeDelete, generate the signal

2011-07-18 Thread Daniel P. Berrange
On Sun, Jul 17, 2011 at 06:45:00PM +0800, Guannan Ren wrote: > --- > src/storage/storage_backend.c |9 > src/storage/storage_driver.c | 83 > - > 2 files changed, 82 insertions(+), 10 deletions(-) > > diff --git a/src/storage/storage_backend.c

[libvirt] [PATCH v2 4/5] In storageVolumeCreateXML, spawn a new thread for volbuilding, in storageVolumeDelete, generate the signal

2011-07-17 Thread Guannan Ren
--- src/storage/storage_backend.c |9 src/storage/storage_driver.c | 83 - 2 files changed, 82 insertions(+), 10 deletions(-) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index f632edd..bc10933 100644 --- a/src/stor