Re: [libvirt] [PATCH v2 5/6] tests: qemuxml2xml: assign device addresses

2016-02-09 Thread Laine Stump
On 02/09/2016 04:19 PM, Cole Robinson wrote: On 02/09/2016 04:17 PM, Laine Stump wrote: On 02/09/2016 10:59 AM, Cole Robinson wrote: We use the PreFormat callback for this. Many test cases need to be extended to pass in proper qemuCaps flags so AssignAddresses doesn't throw errors. One test ca

Re: [libvirt] [PATCH v2 5/6] tests: qemuxml2xml: assign device addresses

2016-02-09 Thread Cole Robinson
On 02/09/2016 04:17 PM, Laine Stump wrote: > On 02/09/2016 10:59 AM, Cole Robinson wrote: >> We use the PreFormat callback for this. Many test cases need to be extended >> to pass in proper qemuCaps flags so AssignAddresses doesn't throw errors. >> >> One test case (pcie-root-port-too-many) is drop

Re: [libvirt] [PATCH v2 5/6] tests: qemuxml2xml: assign device addresses

2016-02-09 Thread Laine Stump
On 02/09/2016 10:59 AM, Cole Robinson wrote: We use the PreFormat callback for this. Many test cases need to be extended to pass in proper qemuCaps flags so AssignAddresses doesn't throw errors. One test case (pcie-root-port-too-many) is dropped, since it was meant only for checking an error con

Re: [libvirt] [PATCH v2 5/6] tests: qemuxml2xml: assign device addresses

2016-02-09 Thread Cole Robinson
On 02/09/2016 03:11 PM, Laine Stump wrote: > On 02/09/2016 10:59 AM, Cole Robinson wrote: >> We use the PreFormat callback for this. Many test cases need to be extended >> to pass in proper qemuCaps flags so AssignAddresses doesn't throw errors. >> >> One test case (pcie-root-port-too-many) is drop

Re: [libvirt] [PATCH v2 5/6] tests: qemuxml2xml: assign device addresses

2016-02-09 Thread Laine Stump
On 02/09/2016 10:59 AM, Cole Robinson wrote: We use the PreFormat callback for this. Many test cases need to be extended to pass in proper qemuCaps flags so AssignAddresses doesn't throw errors. One test case (pcie-root-port-too-many) is dropped, since it was meant only for checking an error con