Re: [libvirt] [PATCH v2 5/7] qemu: driver: Move checkpoint-related code to qemu_checkpoint.c

2019-09-26 Thread Peter Krempa
On Thu, Sep 26, 2019 at 10:38:11 -0500, Eric Blake wrote: > On 9/25/19 7:54 AM, Peter Krempa wrote: > > Move all extensive functions to a new file so that we don't just pile > > everything in the common files. This obviously isn't possible with > > straight code movement as we still need stubs in q

Re: [libvirt] [PATCH v2 5/7] qemu: driver: Move checkpoint-related code to qemu_checkpoint.c

2019-09-26 Thread Eric Blake
On 9/25/19 7:54 AM, Peter Krempa wrote: Move all extensive functions to a new file so that we don't just pile everything in the common files. This obviously isn't possible with straight code movement as we still need stubs in qemu_driver.c Additionally some functions e.g. for looking up a checkp

Re: [libvirt] [PATCH v2 5/7] qemu: driver: Move checkpoint-related code to qemu_checkpoint.c

2019-09-26 Thread Peter Krempa
On Wed, Sep 25, 2019 at 14:54:41 +0200, Peter Krempa wrote: > Move all extensive functions to a new file so that we don't just pile > everything in the common files. This obviously isn't possible with > straight code movement as we still need stubs in qemu_driver.c > > Additionally some functions

[libvirt] [PATCH v2 5/7] qemu: driver: Move checkpoint-related code to qemu_checkpoint.c

2019-09-25 Thread Peter Krempa
Move all extensive functions to a new file so that we don't just pile everything in the common files. This obviously isn't possible with straight code movement as we still need stubs in qemu_driver.c Additionally some functions e.g. for looking up a checkpoint by name were so short that moving the