Re: [libvirt] [PATCH v2 8/8] virsh: Extend virsh dominfo to display if managed state exists

2011-07-18 Thread Osier Yang
于 2011年07月19日 01:37, Eric Blake 写道: On 07/18/2011 11:34 AM, Eric Blake wrote: Here, we print "managed state", but the command that creates that state is called "managedsave", and the API we call is virDomainHasManagedSaveImage. Not to mention that it surpasses 15 columns, which makes the output

Re: [libvirt] [PATCH v2 8/8] virsh: Extend virsh dominfo to display if managed state exists

2011-07-18 Thread Eric Blake
On 07/18/2011 11:34 AM, Eric Blake wrote: Here, we print "managed state", but the command that creates that state is called "managedsave", and the API we call is virDomainHasManagedSaveImage. Not to mention that it surpasses 15 columns, which makes the output not lined up with all the other rows.

Re: [libvirt] [PATCH v2 8/8] virsh: Extend virsh dominfo to display if managed state exists

2011-07-18 Thread Eric Blake
On 07/15/2011 03:06 AM, Osier Yang wrote: --- tools/virsh.c |8 1 files changed, 8 insertions(+), 0 deletions(-) Your rebuttals to my arguments about positioning are sound, so I'm okay with leaving the positioning of this output prior to "Security" strings. However, on re-rea

Re: [libvirt] [PATCH v2 8/8] virsh: Extend virsh dominfo to display if managed state exists

2011-07-18 Thread Osier Yang
于 2011年07月16日 11:11, Osier Yang 写道: 于 2011年07月16日 05:45, Eric Blake 写道: On 07/15/2011 03:06 AM, Osier Yang wrote: --- tools/virsh.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 8a62612..120f3c8 100644 --- a/tools/virsh.c

Re: [libvirt] [PATCH v2 8/8] virsh: Extend virsh dominfo to display if managed state exists

2011-07-15 Thread Osier Yang
于 2011年07月16日 05:45, Eric Blake 写道: On 07/15/2011 03:06 AM, Osier Yang wrote: --- tools/virsh.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 8a62612..120f3c8 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -2366,6 +2366,

Re: [libvirt] [PATCH v2 8/8] virsh: Extend virsh dominfo to display if managed state exists

2011-07-15 Thread Eric Blake
On 07/15/2011 03:06 AM, Osier Yang wrote: > --- > tools/virsh.c |8 > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/tools/virsh.c b/tools/virsh.c > index 8a62612..120f3c8 100644 > --- a/tools/virsh.c > +++ b/tools/virsh.c > @@ -2366,6 +2366,7 @@ cmdDominfo(vshCont

[libvirt] [PATCH v2 8/8] virsh: Extend virsh dominfo to display if managed state exists

2011-07-15 Thread Osier Yang
--- tools/virsh.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 8a62612..120f3c8 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -2366,6 +2366,7 @@ cmdDominfo(vshControl *ctl, const vshCmd *cmd) int autostart; unsign