Re: [libvirt] [PATCH v3 00/14] improve graphics listen configuration

2016-05-17 Thread Christophe Fergeau
On Mon, May 16, 2016 at 10:59:47AM -0400, Cole Robinson wrote: > On 05/13/2016 12:35 PM, Christophe Fergeau wrote: > > Hey, > > > > Something which I forgot to mention/test when going through the first > > iteration is virsh domdisplay, it's currently failing with > > > > > > I think something l

Re: [libvirt] [PATCH v3 00/14] improve graphics listen configuration

2016-05-17 Thread Pavel Hrdina
On Mon, May 16, 2016 at 11:01:30AM -0400, Cole Robinson wrote: > On 05/13/2016 07:39 AM, Pavel Hrdina wrote: > > I forgot to mention that patches 1-4,7,10,11 are already acked. > > > > 1-4 look good to me too at a glance, I suggest pushing them ahead of time > since they are useful on their own.

Re: [libvirt] [PATCH v3 00/14] improve graphics listen configuration

2016-05-16 Thread Cole Robinson
On 05/13/2016 07:39 AM, Pavel Hrdina wrote: > I forgot to mention that patches 1-4,7,10,11 are already acked. > 1-4 look good to me too at a glance, I suggest pushing them ahead of time since they are useful on their own. I'll try and review the rest now - Cole -- libvir-list mailing list libvi

Re: [libvirt] [PATCH v3 00/14] improve graphics listen configuration

2016-05-16 Thread Cole Robinson
On 05/13/2016 12:35 PM, Christophe Fergeau wrote: > Hey, > > Something which I forgot to mention/test when going through the first > iteration is virsh domdisplay, it's currently failing with > > > I think something like 'spice+unix:///tmp/foo' is expected. This can be > addressed as a follow-up

Re: [libvirt] [PATCH v3 00/14] improve graphics listen configuration

2016-05-13 Thread Christophe Fergeau
Hey, Something which I forgot to mention/test when going through the first iteration is virsh domdisplay, it's currently failing with I think something like 'spice+unix:///tmp/foo' is expected. This can be addressed as a follow-up to this series though. Christophe On Thu, May 12, 2016 at 05:15

Re: [libvirt] [PATCH v3 00/14] improve graphics listen configuration

2016-05-13 Thread Pavel Hrdina
I forgot to mention that patches 1-4,7,10,11 are already acked. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v3 00/14] improve graphics listen configuration

2016-05-12 Thread Pavel Hrdina
This patch series improves the way how different listen types can be specified and also introduce a new listen types for graphics devices. First improvement is to move ports out of graphics element into listen element with type address or network. This is a first step to make the code listen-driv