Re: [libvirt] [PATCH v3 02/12] qemu: Create new qemuDomainDeviceDefValidateControllerPCI()

2018-03-02 Thread Laine Stump
On 03/02/2018 08:05 AM, Andrea Bolognani wrote: > On Fri, 2018-03-02 at 07:34 -0500, Laine Stump wrote: >> On 02/21/2018 09:14 AM, Andrea Bolognani wrote: > [...] >>> +static int >>> +qemuDomainDeviceDefValidateControllerPCI(const virDomainControllerDef >>> *cont, >>> +

Re: [libvirt] [PATCH v3 02/12] qemu: Create new qemuDomainDeviceDefValidateControllerPCI()

2018-03-02 Thread Andrea Bolognani
On Fri, 2018-03-02 at 07:34 -0500, Laine Stump wrote: > On 02/21/2018 09:14 AM, Andrea Bolognani wrote: [...] > > +static int > > +qemuDomainDeviceDefValidateControllerPCI(const virDomainControllerDef > > *cont, > > + const virDomainDef *def, > > +

Re: [libvirt] [PATCH v3 02/12] qemu: Create new qemuDomainDeviceDefValidateControllerPCI()

2018-03-02 Thread Laine Stump
On 02/21/2018 09:14 AM, Andrea Bolognani wrote: > The esisting function is renamed and called from the new one, so > that even while we're in the process of implementing new checks > all the existing ones will be performed. > > Signed-off-by: Andrea Bolognani > --- > Based on the reviewer's prefer

[libvirt] [PATCH v3 02/12] qemu: Create new qemuDomainDeviceDefValidateControllerPCI()

2018-02-21 Thread Andrea Bolognani
The esisting function is renamed and called from the new one, so that even while we're in the process of implementing new checks all the existing ones will be performed. Signed-off-by: Andrea Bolognani --- Based on the reviewer's preference, this patch can be pushed on its own or squashed into th