Re: [libvirt] [PATCH v3 03/13] security: Always spawn process for transactions

2018-11-14 Thread Daniel P . Berrangé
On Tue, Nov 13, 2018 at 03:52:17PM -0500, John Ferlan wrote: > [...] > >> > >> I understand (generically) why we need the lock. I'm OK with it being > >> enabled by default. That's not the question/ask. Building in a way to > >> allow disabling usage of virFork and/or metadata lock knowing the > >>

Re: [libvirt] [PATCH v3 03/13] security: Always spawn process for transactions

2018-11-13 Thread John Ferlan
[...] >> >> I understand (generically) why we need the lock. I'm OK with it being >> enabled by default. That's not the question/ask. Building in a way to >> allow disabling usage of virFork and/or metadata lock knowing the >> "penalty" or downside to doing so goes beyond bug free or performance, >

Re: [libvirt] [PATCH v3 03/13] security: Always spawn process for transactions

2018-11-12 Thread Michal Privoznik
On 11/09/2018 03:02 PM, John Ferlan wrote: > > > On 11/9/18 7:42 AM, Michal Privoznik wrote: >> On 11/08/2018 11:45 PM, John Ferlan wrote: >>> >>> >>> On 10/17/18 5:06 AM, Michal Privoznik wrote: In the next commit the virSecurityManagerMetadataLock() is going to be turned thread unsafe

Re: [libvirt] [PATCH v3 03/13] security: Always spawn process for transactions

2018-11-09 Thread John Ferlan
On 11/9/18 7:42 AM, Michal Privoznik wrote: > On 11/08/2018 11:45 PM, John Ferlan wrote: >> >> >> On 10/17/18 5:06 AM, Michal Privoznik wrote: >>> In the next commit the virSecurityManagerMetadataLock() is going >>> to be turned thread unsafe. Therefore, we have to spawn a >>> separate process f

Re: [libvirt] [PATCH v3 03/13] security: Always spawn process for transactions

2018-11-09 Thread Michal Privoznik
On 11/08/2018 11:45 PM, John Ferlan wrote: > > > On 10/17/18 5:06 AM, Michal Privoznik wrote: >> In the next commit the virSecurityManagerMetadataLock() is going >> to be turned thread unsafe. Therefore, we have to spawn a >> separate process for it. Always. >> >> Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH v3 03/13] security: Always spawn process for transactions

2018-11-08 Thread John Ferlan
On 10/17/18 5:06 AM, Michal Privoznik wrote: > In the next commit the virSecurityManagerMetadataLock() is going > to be turned thread unsafe. Therefore, we have to spawn a > separate process for it. Always. > > Signed-off-by: Michal Privoznik > --- > src/security/security_dac.c | 2 +- >

[libvirt] [PATCH v3 03/13] security: Always spawn process for transactions

2018-10-17 Thread Michal Privoznik
In the next commit the virSecurityManagerMetadataLock() is going to be turned thread unsafe. Therefore, we have to spawn a separate process for it. Always. Signed-off-by: Michal Privoznik --- src/security/security_dac.c | 2 +- src/security/security_selinux.c | 2 +- 2 files changed, 2 inser