Re: [libvirt] [PATCH v3 1/2] network: Introduce network hooks

2014-02-11 Thread Michal Privoznik
On 11.02.2014 10:54, Daniel P. Berrange wrote: On Mon, Feb 10, 2014 at 07:52:34PM +0100, Michal Privoznik wrote: @@ -3583,6 +3639,48 @@ validate: } } +/* finally we can call the 'plugged' hook script if any */ +if (virHookPresent(VIR_HOOK_DRIVER_NETWORK)) { +/*

Re: [libvirt] [PATCH v3 1/2] network: Introduce network hooks

2014-02-11 Thread Daniel P. Berrange
On Mon, Feb 10, 2014 at 07:52:34PM +0100, Michal Privoznik wrote: > @@ -3583,6 +3639,48 @@ validate: > } > } > > +/* finally we can call the 'plugged' hook script if any */ > +if (virHookPresent(VIR_HOOK_DRIVER_NETWORK)) { > +/* the XML construction is a bit complic

[libvirt] [PATCH v3 1/2] network: Introduce network hooks

2014-02-10 Thread Michal Privoznik
There might be some use cases, where user wants to prepare the host or its environment prior to starting a network and do some cleanup after the network has been shut down. Consider all the functionality that libvirt doesn't currently have as an example what a hook script can possibly do. Signed-o