Re: [libvirt] [PATCH v3 2/2] Test network update XML parsing

2013-08-27 Thread Ján Tomko
On 08/27/2013 10:39 PM, Laine Stump wrote: > On 08/26/2013 11:43 AM, Ján Tomko wrote: >> Add checks for updating sections of network definition via >> virNetworkDefUpdateSection. >> > > ACK. This is a good start on testing this part of the code. (In order to > test higher level functionality, we p

Re: [libvirt] [PATCH v3 2/2] Test network update XML parsing

2013-08-27 Thread Laine Stump
On 08/26/2013 11:43 AM, Ján Tomko wrote: > Add checks for updating sections of network definition via > virNetworkDefUpdateSection. > ACK. This is a good start on testing this part of the code. (In order to test higher level functionality, we probably need to restructure bridge_driver.c so that it

[libvirt] [PATCH v3 2/2] Test network update XML parsing

2013-08-26 Thread Ján Tomko
Add checks for updating sections of network definition via virNetworkDefUpdateSection. https://bugzilla.redhat.com/show_bug.cgi?id=989569 --- src/conf/network_conf.c| 2 +- src/conf/network_conf.h| 9 + src/libvirt_private.syms