Re: [libvirt] [PATCH v3 22/36] network: remove the virDomainNetBandwidthChangeAllowed callback

2019-04-04 Thread Daniel P . Berrangé
On Tue, Apr 02, 2019 at 09:22:38PM -0400, Laine Stump wrote: > On 3/19/19 8:46 AM, Daniel P. Berrangé wrote: > > The current qemu driver code for changing bandwidth on a NIC first asks > > the network driver if the change is supported, then changes the > > bandwidth on the VIF, and then tells the n

Re: [libvirt] [PATCH v3 22/36] network: remove the virDomainNetBandwidthChangeAllowed callback

2019-04-02 Thread Laine Stump
On 3/19/19 8:46 AM, Daniel P. Berrangé wrote: The current qemu driver code for changing bandwidth on a NIC first asks the network driver if the change is supported, then changes the bandwidth on the VIF, and then tells the network driver to update the bandwidth on the bridge. This is potentially

[libvirt] [PATCH v3 22/36] network: remove the virDomainNetBandwidthChangeAllowed callback

2019-03-19 Thread Daniel P . Berrangé
The current qemu driver code for changing bandwidth on a NIC first asks the network driver if the change is supported, then changes the bandwidth on the VIF, and then tells the network driver to update the bandwidth on the bridge. This is potentially racing if a parallel API call causes the networ