Re: [libvirt] [PATCH v3 3/5] qemu: Use virJSONValueObjectCreate for master key

2016-06-06 Thread Peter Krempa
On Mon, Jun 06, 2016 at 07:14:00 -0400, John Ferlan wrote: > > > On 06/06/2016 03:23 AM, Peter Krempa wrote: > > On Fri, Jun 03, 2016 at 06:52:51 -0400, John Ferlan wrote: > >> Rather than open coding, follow the secinfo code and use the common > >> secret object build/generate sequence. > > > >

Re: [libvirt] [PATCH v3 3/5] qemu: Use virJSONValueObjectCreate for master key

2016-06-06 Thread John Ferlan
On 06/06/2016 03:23 AM, Peter Krempa wrote: > On Fri, Jun 03, 2016 at 06:52:51 -0400, John Ferlan wrote: >> Rather than open coding, follow the secinfo code and use the common >> secret object build/generate sequence. > > The main reason to do this was to have a single code path that generates >

Re: [libvirt] [PATCH v3 3/5] qemu: Use virJSONValueObjectCreate for master key

2016-06-06 Thread Peter Krempa
On Fri, Jun 03, 2016 at 06:52:51 -0400, John Ferlan wrote: > Rather than open coding, follow the secinfo code and use the common > secret object build/generate sequence. The main reason to do this was to have a single code path that generates properties both for adding the object to qemu via comma

[libvirt] [PATCH v3 3/5] qemu: Use virJSONValueObjectCreate for master key

2016-06-03 Thread John Ferlan
Rather than open coding, follow the secinfo code and use the common secret object build/generate sequence. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_com