Re: [libvirt] [PATCH v3 4/5] qemu: add support for Direct Mode for Hyper-V Synthetic timers

2019-08-09 Thread Vitaly Kuznetsov
Ján Tomko writes: > Either leave this as-is and add the new feature in a separate test, > or you can branch the test based on QEMU versions like we do for other > features: > > DO_TEST_CAPS_VER("pv-spinlock-disabled", "2.7.0"); > DO_TEST_CAPS_VER("pv-spinlock-disabled", "4.0.0"); > DO

Re: [libvirt] [PATCH v3 4/5] qemu: add support for Direct Mode for Hyper-V Synthetic timers

2019-08-09 Thread Ján Tomko
On Fri, Aug 09, 2019 at 12:13:45PM +0200, Vitaly Kuznetsov wrote: Ján Tomko writes: One more thing, qemuxml2argvtest is using DO_TEST: DO_TEST("hyperv", NONE); DO_TEST("hyperv-off", NONE); DO_TEST("hyperv-panic", NONE); which manually enumarate the used QEMU capabilities (although

Re: [libvirt] [PATCH v3 4/5] qemu: add support for Direct Mode for Hyper-V Synthetic timers

2019-08-09 Thread Vitaly Kuznetsov
Ján Tomko writes: > One more thing, qemuxml2argvtest is using DO_TEST: > DO_TEST("hyperv", NONE); > DO_TEST("hyperv-off", NONE); > DO_TEST("hyperv-panic", NONE); > which manually enumarate the used QEMU capabilities (although there are > none here) > > DO_TEST_CAPS_LATEST is the way t

Re: [libvirt] [PATCH v3 4/5] qemu: add support for Direct Mode for Hyper-V Synthetic timers

2019-08-06 Thread Ján Tomko
On Tue, Aug 06, 2019 at 01:25:37PM +0200, Ján Tomko wrote: On Tue, Aug 06, 2019 at 07:52:35AM +0200, Vitaly Kuznetsov wrote: QEMU-4.1 supports 'Direct Mode' for Hyper-V synthetic timers (hv-stimer-direct CPU flag): Windows guests can request that timer expiration notifications are delivered as n

Re: [libvirt] [PATCH v3 4/5] qemu: add support for Direct Mode for Hyper-V Synthetic timers

2019-08-06 Thread Ján Tomko
On Tue, Aug 06, 2019 at 07:52:35AM +0200, Vitaly Kuznetsov wrote: QEMU-4.1 supports 'Direct Mode' for Hyper-V synthetic timers (hv-stimer-direct CPU flag): Windows guests can request that timer expiration notifications are delivered as normal interrupts (and not VMBus messages). This is used by H

[libvirt] [PATCH v3 4/5] qemu: add support for Direct Mode for Hyper-V Synthetic timers

2019-08-05 Thread Vitaly Kuznetsov
QEMU-4.1 supports 'Direct Mode' for Hyper-V synthetic timers (hv-stimer-direct CPU flag): Windows guests can request that timer expiration notifications are delivered as normal interrupts (and not VMBus messages). This is used by Hyper-V on KVM. Signed-off-by: Vitaly Kuznetsov --- src/qemu/qemu_