Re: [libvirt] [PATCH v3 4/8] test: Implement snapshot create/delete/revert APIs

2013-10-04 Thread Cole Robinson
On 10/04/2013 07:05 AM, John Ferlan wrote: > On 09/25/2013 03:15 PM, Cole Robinson wrote: >> Again stolen from qemu_driver.c, but dropping all the unneeded bits. >> This aims to copy all the current qemu validation checks since that's >> the most commonly used real driver, but some of the checks ar

Re: [libvirt] [PATCH v3 4/8] test: Implement snapshot create/delete/revert APIs

2013-10-04 Thread John Ferlan
On 09/25/2013 03:15 PM, Cole Robinson wrote: > Again stolen from qemu_driver.c, but dropping all the unneeded bits. > This aims to copy all the current qemu validation checks since that's > the most commonly used real driver, but some of the checks are > completely artificial in the test driver. >

Re: [libvirt] [PATCH v3 4/8] test: Implement snapshot create/delete/revert APIs

2013-10-03 Thread Cole Robinson
On 09/26/2013 10:44 AM, Michal Privoznik wrote: > On 25.09.2013 21:15, Cole Robinson wrote: >> Again stolen from qemu_driver.c, but dropping all the unneeded bits. >> This aims to copy all the current qemu validation checks since that's >> the most commonly used real driver, but some of the checks

Re: [libvirt] [PATCH v3 4/8] test: Implement snapshot create/delete/revert APIs

2013-09-26 Thread Michal Privoznik
On 25.09.2013 21:15, Cole Robinson wrote: > Again stolen from qemu_driver.c, but dropping all the unneeded bits. > This aims to copy all the current qemu validation checks since that's > the most commonly used real driver, but some of the checks are > completely artificial in the test driver. > >

[libvirt] [PATCH v3 4/8] test: Implement snapshot create/delete/revert APIs

2013-09-25 Thread Cole Robinson
Again stolen from qemu_driver.c, but dropping all the unneeded bits. This aims to copy all the current qemu validation checks since that's the most commonly used real driver, but some of the checks are completely artificial in the test driver. This only supports creation of internal snapshots for