Re: [libvirt] [PATCH v3 5/5] qemu: auto-add bridges and allow using them

2013-04-25 Thread Michal Privoznik
On 22.04.2013 20:43, Ján Tomko wrote: > Add a "dry run" address allocation to figure out how many bridges > will be needed for all the devices without explicit addresses. > > Auto-add just enough bridges to put all the devices on, or up to the > bridge with the largest specified index. > --- > sr

Re: [libvirt] [PATCH v3 5/5] qemu: auto-add bridges and allow using them

2013-04-23 Thread Ján Tomko
On 04/23/2013 12:24 AM, Eric Blake wrote: > On 04/22/2013 12:43 PM, Ján Tomko wrote: >> qemuDomainPCIAddressGetNextSlot(qemuDomainPCIAddressSetPtr addrs, >> virDevicePCIAddressPtr next_addr) >> { >> -virDevicePCIAddress tmp_addr = addrs->lastaddr; >> -int

Re: [libvirt] [PATCH v3 5/5] qemu: auto-add bridges and allow using them

2013-04-22 Thread Eric Blake
On 04/22/2013 12:43 PM, Ján Tomko wrote: > Add a "dry run" address allocation to figure out how many bridges > will be needed for all the devices without explicit addresses. > > Auto-add just enough bridges to put all the devices on, or up to the > bridge with the largest specified index. > --- I

Re: [libvirt] [PATCH v3 5/5] qemu: auto-add bridges and allow using them

2013-04-22 Thread Laine Stump
(before anything else - you committed an unresolved merge conflict in qemu_command.h. You'll need to remove the extra "> blah" text.) Hopefully Eric can once again review the logic of the code that determines what bridges need to be auto-added, and assign PCI addresses to devices, since he

[libvirt] [PATCH v3 5/5] qemu: auto-add bridges and allow using them

2013-04-22 Thread Ján Tomko
Add a "dry run" address allocation to figure out how many bridges will be needed for all the devices without explicit addresses. Auto-add just enough bridges to put all the devices on, or up to the bridge with the largest specified index. --- src/conf/domain_conf.c |