Re: [libvirt] [PATCH v3 UPDATED 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

2012-11-22 Thread Harsh Bora
On 11/22/2012 07:05 PM, Eric Blake wrote: On 11/22/2012 01:49 AM, Harsh Bora wrote: +transp = strstr(uri->scheme, "+"); strstr() for a single-byte needle is overkill. +transp++; You could even squash the increment into the previous line :-) That would give me: qemu/qemu

Re: [libvirt] [PATCH v3 UPDATED 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

2012-11-22 Thread Eric Blake
On 11/22/2012 01:49 AM, Harsh Bora wrote: >>> +transp = strstr(uri->scheme, "+"); strstr() for a single-byte needle is overkill. >>> +transp++; >> >> You could even squash the increment into the previous line :-) > > That would give me: > > qemu/qemu_command.c: In function 'qem

Re: [libvirt] [PATCH v3 UPDATED 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

2012-11-22 Thread Harsh Bora
On 11/16/2012 03:53 AM, Jiri Denemark wrote: On Fri, Oct 26, 2012 at 22:27:35 +0530, Harsh Prateek Bora wrote: Qemu accepts gluster protocol as supported storage backend beside others. This patch allows users to specify disks on gluster backends like this:

Re: [libvirt] [PATCH v3 UPDATED 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

2012-11-15 Thread Jiri Denemark
On Fri, Oct 26, 2012 at 22:27:35 +0530, Harsh Prateek Bora wrote: > Qemu accepts gluster protocol as supported storage backend beside others. > This patch allows users to specify disks on gluster backends like this: > > > > > > > > > > In the elemen

[libvirt] [PATCH v3 UPDATED 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

2012-10-26 Thread Harsh Prateek Bora
Qemu accepts gluster protocol as supported storage backend beside others. This patch allows users to specify disks on gluster backends like this: In the element above, transport is a new optional attribute. Valid transport values are tcp, unix or rd