Re: [libvirt] [PATCH v3.5 14/18] qemu: only force an available legacy-PCI slot on domains with pci-root

2016-10-06 Thread Andrea Bolognani
On Thu, 2016-10-06 at 12:04 -0400, Laine Stump wrote: > > Since now you're using info exclusively inside this block, > > you can move its declaration here as well. > > Except that patch 19/18 uses it too (it was that patch that led to me > re-doing this one and posting a v3.5) Nevermind then :)

Re: [libvirt] [PATCH v3.5 14/18] qemu: only force an available legacy-PCI slot on domains with pci-root

2016-10-06 Thread Laine Stump
On 10/06/2016 11:39 AM, Andrea Bolognani wrote: On Thu, 2016-09-29 at 10:14 -0400, Laine Stump wrote: Andrea had the right idea when he disabled the "reserve an extra unused slot" bit for aarch64/virt. For *any* PCI Express-based machine, it is pointless since 1) an extra legacy-PCI slot can't b

Re: [libvirt] [PATCH v3.5 14/18] qemu: only force an available legacy-PCI slot on domains with pci-root

2016-10-06 Thread Andrea Bolognani
On Thu, 2016-09-29 at 10:14 -0400, Laine Stump wrote: > Andrea had the right idea when he disabled the "reserve an extra > unused slot" bit for aarch64/virt. For *any* PCI Express-based > machine, it is pointless since 1) an extra legacy-PCI slot can't be > used for hotplug, since hotplug into lega

[libvirt] [PATCH v3.5 14/18] qemu: only force an available legacy-PCI slot on domains with pci-root

2016-09-29 Thread Laine Stump
Andrea had the right idea when he disabled the "reserve an extra unused slot" bit for aarch64/virt. For *any* PCI Express-based machine, it is pointless since 1) an extra legacy-PCI slot can't be used for hotplug, since hotplug into legacy PCI slots doesn't work on PCI Express machinetypes, and 2)