Re: [libvirt] [PATCH v4] qemu: qemuDomainChangeNet: validity checks should be done before XML autocompletion

2018-08-27 Thread Ján Tomko
On Mon, Aug 27, 2018 at 09:50:07AM +0200, Katerina Koukiou wrote: This patch ensures that changes in attributes of interfaces will emit errors accept if they are missing from the XML. except Previously we were falsely reporting successful updates, because some changed attributes got overwritt

[libvirt] [PATCH v4] qemu: qemuDomainChangeNet: validity checks should be done before XML autocompletion

2018-08-27 Thread Katerina Koukiou
This patch ensures that changes in attributes of interfaces will emit errors accept if they are missing from the XML. Previously we were falsely reporting successful updates, because some changed attributes got overwritten before the validity checks. https://bugzilla.redhat.com/show_bug.cgi?id=159