Re: [libvirt] [PATCH v4 01/11] Add QMP probing for TPM

2013-04-16 Thread Daniel P. Berrange
On Mon, Apr 15, 2013 at 01:32:53PM -0400, Stefan Berger wrote: > On 04/15/2013 12:56 PM, Daniel P. Berrange wrote: > > > >Guess you never tested this on a QEMU which lacked those commands. > >Probing capabilities now fails for any QEMU using QMP which lacks > >these commands > > Indeed, all the

Re: [libvirt] [PATCH v4 01/11] Add QMP probing for TPM

2013-04-15 Thread Stefan Berger
On 04/15/2013 12:56 PM, Daniel P. Berrange wrote: Guess you never tested this on a QEMU which lacked those commands. Probing capabilities now fails for any QEMU using QMP which lacks these commands Indeed, all the executables it checks have TPM enabled by now. What's the best way of suppress

Re: [libvirt] [PATCH v4 01/11] Add QMP probing for TPM

2013-04-15 Thread Daniel P. Berrange
On Fri, Apr 05, 2013 at 10:05:52AM -0400, Stefan Berger wrote: > Probe for QEMU's QMP TPM support by querying the lists of > supported TPM models (query-tpm-models) and backend types > (query-tpm-types). > > The setting of the capability flags following the strings > returned from the commands ab

Re: [libvirt] [PATCH v4 01/11] Add QMP probing for TPM

2013-04-11 Thread Daniel P. Berrange
On Fri, Apr 05, 2013 at 10:05:52AM -0400, Stefan Berger wrote: > Probe for QEMU's QMP TPM support by querying the lists of > supported TPM models (query-tpm-models) and backend types > (query-tpm-types). > > The setting of the capability flags following the strings > returned from the commands ab

[libvirt] [PATCH v4 01/11] Add QMP probing for TPM

2013-04-05 Thread Stefan Berger
Probe for QEMU's QMP TPM support by querying the lists of supported TPM models (query-tpm-models) and backend types (query-tpm-types). The setting of the capability flags following the strings returned from the commands above is only provided in the patch where domain_conf.c gets TPM support due