Re: [libvirt] [PATCH v4 01/13] qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes

2018-01-05 Thread John Ferlan
On 01/05/2018 10:20 AM, Marc Hartmayer wrote: > On Thu, Jan 04, 2018 at 02:12 PM +0100, John Ferlan > wrote: >> On 01/04/2018 05:23 AM, Marc Hartmayer wrote: >>> On Tue, Dec 12, 2017 at 04:06 PM +0100, John Ferlan >>> wrote: Move the checks that various attributes are not set on any cont

Re: [libvirt] [PATCH v4 01/13] qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes

2018-01-05 Thread Marc Hartmayer
On Thu, Jan 04, 2018 at 02:12 PM +0100, John Ferlan wrote: > On 01/04/2018 05:23 AM, Marc Hartmayer wrote: >> On Tue, Dec 12, 2017 at 04:06 PM +0100, John Ferlan >> wrote: >>> Move the checks that various attributes are not set on any controller >>> other than SCSI controller using virtio-scsi m

Re: [libvirt] [PATCH v4 01/13] qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes

2018-01-04 Thread John Ferlan
On 01/04/2018 05:23 AM, Marc Hartmayer wrote: > On Tue, Dec 12, 2017 at 04:06 PM +0100, John Ferlan > wrote: >> Move the checks that various attributes are not set on any controller >> other than SCSI controller using virtio-scsi model into the common >> controller validate checks. > > You not

Re: [libvirt] [PATCH v4 01/13] qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes

2018-01-04 Thread Marc Hartmayer
On Tue, Dec 12, 2017 at 04:06 PM +0100, John Ferlan wrote: > Move the checks that various attributes are not set on any controller > other than SCSI controller using virtio-scsi model into the common > controller validate checks. You not only move the checks, but also add the call 'qemuDomainSetS

[libvirt] [PATCH v4 01/13] qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes

2017-12-12 Thread John Ferlan
Move the checks that various attributes are not set on any controller other than SCSI controller using virtio-scsi model into the common controller validate checks. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 24 src/qemu/qemu_domain.c | 41