Re: [libvirt] [PATCH v4 03/11] nvdimm: introduce 'unarmed' element into xml for NVDIMM memory

2018-12-19 Thread Zhong, Luyao
On 12/20/2018 12:07 AM, Daniel P. Berrangé wrote: On Tue, Dec 18, 2018 at 09:50:40AM +0800, Luyao Zhong wrote: On 2018/12/17 下午7:07, Daniel P. Berrangé wrote: On Mon, Dec 17, 2018 at 05:26:13PM +0800, Luyao Zhong wrote: The 'unarmed' option allows users to mark vNVDIMM read-only: Why don

Re: [libvirt] [PATCH v4 03/11] nvdimm: introduce 'unarmed' element into xml for NVDIMM memory

2018-12-19 Thread Daniel P . Berrangé
On Tue, Dec 18, 2018 at 09:50:40AM +0800, Luyao Zhong wrote: > > > On 2018/12/17 下午7:07, Daniel P. Berrangé wrote: > > On Mon, Dec 17, 2018 at 05:26:13PM +0800, Luyao Zhong wrote: > > > The 'unarmed' option allows users to mark vNVDIMM read-only: > > > > Why don't we call this element then ? >

Re: [libvirt] [PATCH v4 03/11] nvdimm: introduce 'unarmed' element into xml for NVDIMM memory

2018-12-17 Thread Luyao Zhong
On 2018/12/17 下午7:07, Daniel P. Berrangé wrote: On Mon, Dec 17, 2018 at 05:26:13PM +0800, Luyao Zhong wrote: The 'unarmed' option allows users to mark vNVDIMM read-only: Why don't we call this element then ? Just keep the same with QEMU, hah~ :) ... /dev/dax

Re: [libvirt] [PATCH v4 03/11] nvdimm: introduce 'unarmed' element into xml for NVDIMM memory

2018-12-17 Thread Daniel P . Berrangé
On Mon, Dec 17, 2018 at 05:26:13PM +0800, Luyao Zhong wrote: > The 'unarmed' option allows users to mark vNVDIMM read-only: Why don't we call this element then ? > > > ... > > > /dev/dax0.0 > > > 4094 > 0 > > 2 >

[libvirt] [PATCH v4 03/11] nvdimm: introduce 'unarmed' element into xml for NVDIMM memory

2018-12-17 Thread Luyao Zhong
The 'unarmed' option allows users to mark vNVDIMM read-only: ... /dev/dax0.0 4094 0 2 ... Signed-off-by: Luyao Zhong --- docs/formatdomain.html.in | 45 +