Re: [libvirt] [PATCH v4 2/8] snapshot: Support topological virDomainSnapshotForEach()

2019-03-12 Thread Eric Blake
On 3/12/19 8:00 AM, Ján Tomko wrote: > On Mon, Mar 11, 2019 at 09:38:33PM -0500, Eric Blake wrote: >> Previous patches added topological sorting only for existing public >> API functions, but it turns out that it will also useful for an >> upcoming API addition that wants to visit all snapshots.  A

Re: [libvirt] [PATCH v4 2/8] snapshot: Support topological virDomainSnapshotForEach()

2019-03-12 Thread Ján Tomko
On Mon, Mar 11, 2019 at 09:38:33PM -0500, Eric Blake wrote: Previous patches added topological sorting only for existing public API functions, but it turns out that it will also useful for an upcoming API addition that wants to visit all snapshots. Add a parameter, and update all existing caller

[libvirt] [PATCH v4 2/8] snapshot: Support topological virDomainSnapshotForEach()

2019-03-11 Thread Eric Blake
Previous patches added topological sorting only for existing public API functions, but it turns out that it will also useful for an upcoming API addition that wants to visit all snapshots. Add a parameter, and update all existing callers (none of which care about ordering). Signed-off-by: Eric Bl